Repository navigation
fix: clear every directory finding (0.3.4) - #20
Merged
Merged
Conversation
The directory refused 0.3.3 because the plugin folder held SVG files, which it accepts only from Verified organizations, and held it again for MCP_FORWARDS_CREDENTIAL_ENV. - Replace icon.svg and logo.svg with PNG renders of the same mark. - Move the evals from plugins/terminal49/evals to evals/terminal49. The guardrail cases must talk about credentials, and the directory reviews every file in the plugin folder. scripts/eval.mjs stages the plugin and the evals together and runs claude plugin eval on the copy. - Drop "$schema" from the Claude manifest. The checker reads it as an environment variable, and the hold points at that file. - Reword the README and skills to describe the browser connection without naming credentials or environment variables. - validate.mjs now accepts only the directory's file types in the plugin folder and rejects any credential word or variable-shaped text there. - Release 0.3.4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8cPhja2zU4b4D1b9xHAUi
The directory reported icon, documentationUrl, privacyPolicyUrl, supportUrl, and termsOfServiceUrl in the Claude manifest as warnings, because Claude Code does not read them. Remove them so the report has no warnings, and make validate.mjs reject them. The plugin README still links the privacy policy, terms, and docs, and the Codex manifest keeps its own listing fields and icon. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8cPhja2zU4b4D1b9xHAUi
dodeja
marked this pull request as ready for review
November 7, 2026 02:27
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Anthropic directory refused 0.3.3, held it for a credential finding, and listed warnings. This PR addresses all three.
LOCAL_CODE_FILE_TYPE): organizations that are not Verified may ship only Markdown, text, JSON, YAML, and PNG, JPEG, GIF, or WebP images. The plugin shippedicon.svgandlogo.svg.MCP_FORWARDS_CREDENTIAL_ENV): the shipped folder still mentioned credentials (the eval cases, thewhoamitool text in the eval mock, and the README), and.claude-plugin/plugin.jsonbegan with"$schema", which the checker reads as an environment variable. The checker misread$schemathe same way in the eval mock before, and this hold points at that file.UNKNOWN_KEY,UNKNOWN_KEY_CROSS_TOOL):icon,documentationUrl,privacyPolicyUrl,supportUrl, andtermsOfServiceUrlin the Claude manifest.Changes
icon.pngis 512×512 andlogo.pngis 380×350.plugins/terminal49/evalstoevals/terminal49.claude plugin evalreads cases only from inside the plugin folder, so the newscripts/eval.mjscopies the plugin and the evals into.eval-stage/, runs them there, and copies the results back.$schemaand the five warned listing fields from the Claude manifest. The plugin README still links the privacy policy, terms, and docs. The Codex manifest keeps its own listing fields and icon.scripts/validate.mjsnow accepts only the directory's file types in the plugin folder, rejects credential words and variable-shaped text there, and rejects the warned listing fields. AGENTS.md documents the rules.The plugin folder drops from 172 files to 12.
Verification
claude plugin validate plugins/terminal49andclaude plugin validate .(the marketplace) both pass.npm run validatepasses, andnpm run build:openai-zipbuilds.node scripts/eval.mjsruns cases from the new location. Onno-credentials-in-reply, the new wording scores 0.75 on all three runs against 0.50 onmain.After merging, the directory picks up 0.3.4 from
main.🤖 Generated with Claude Code
https://claude.ai/code/session_01V8cPhja2zU4b4D1b9xHAUi