Skip to content

Fix SGR handler treating prefixed CSI sequences (e.g. XTMODKEYS) as SGR #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smohekey wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix SGR handler treating prefixed CSI sequences (e.g. XTMODKEYS) as SGR #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/src/core/escape/parser.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,13 @@ class EscapeParser {
///
/// https://terminalguide.namepad.de/seq/csi_sm/
void _csiHandleSgr() {
// SGR is `CSI Ps m` and never carries a private prefix. Sequences that share the final byte `m`
// but have a prefix are not SGR — e.g. XTMODKEYS `CSI > Ps ; Ps m` (modifyOtherKeys), which many
// terminals/apps emit. Dispatching on the final byte alone runs those through the SGR handler,
// which then reads their parameters as SGR codes (so `CSI > 4 ; 2 m` turns on underline for every
// subsequent cell). Ignore prefixed sequences here.
if (_csi.prefix != null) return;

final params = _csi.params;

if (params.isEmpty) {
Expand Down