Skip to content

Fix incorrect absolute minimum calculation #7536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
klerk1t wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −11
Open

Fix incorrect absolute minimum calculation #7536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b81bc37
Fix incorrect absolute minimum calculation
klerk1t Jul 21, 2026
b8c0c4c
Fix incorrect absolute minimum calculation
klerk1t Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/main/java/com/thealgorithms/maths/AbsoluteMin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.thealgorithms.maths;

import java.util.Arrays;

public final class AbsoluteMin {
private AbsoluteMin() {
}
Expand All @@ -13,14 +11,16 @@ private AbsoluteMin() {
* @return The absolute min value
*/
public static int getMinValue(int... numbers) {
if (numbers.length == 0) {
throw new IllegalArgumentException("Numbers array cannot be empty");
if (numbers == null || numbers.length == 0) {
throw new IllegalArgumentException("Numbers array cannot be empty or null");
}

var absMinWrapper = new Object() { int value = numbers[0]; };

Arrays.stream(numbers).skip(1).filter(number -> Math.abs(number) <= Math.abs(absMinWrapper.value)).forEach(number -> absMinWrapper.value = Math.min(absMinWrapper.value, number));

return absMinWrapper.value;
int absMin = numbers[0];
for (int i = 1; i < numbers.length; i++) {
if (Math.abs(numbers[i]) < Math.abs(absMin) || (Math.abs(numbers[i]) == Math.abs(absMin) && numbers[i] < absMin)) {
absMin = numbers[i];
}
}
return absMin;
}
}
7 changes: 5 additions & 2 deletions src/test/java/com/thealgorithms/maths/AbsoluteMinTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,15 @@ public class AbsoluteMinTest {
void testGetMinValue() {
assertEquals(0, AbsoluteMin.getMinValue(4, 0, 16));
assertEquals(-2, AbsoluteMin.getMinValue(3, -10, -2));
assertEquals(-2, AbsoluteMin.getMinValue(-3, -10, -2));
assertEquals(2, AbsoluteMin.getMinValue(-3, -10, 2));
assertEquals(2, AbsoluteMin.getMinValue(-5, 2));
assertEquals(2, AbsoluteMin.getMinValue(2, -5));
}

@Test
void testGetMinValueWithNoArguments() {
Exception exception = assertThrows(IllegalArgumentException.class, AbsoluteMin::getMinValue);
assertEquals("Numbers array cannot be empty", exception.getMessage());
assertThrows(IllegalArgumentException.class, AbsoluteMin::getMinValue);
}

@Test
Expand Down
Loading