fix: add input validation to cyclic_sort to prevent infinite loop#14946
Open
mithunbabbira wants to merge 1 commit into
Open
fix: add input validation to cyclic_sort to prevent infinite loop#14946mithunbabbira wants to merge 1 commit into
mithunbabbira wants to merge 1 commit into
Conversation
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes #14898
cyclic_sorthad no input validation. Inputs with duplicates caused an infinite loop, and out-of-range values silently produced wrong output.Added validation matching the issue's expected behavior:
ValueError: All numbers must be unique, got [...]ValueError: All numbers must be in range 1 to n, got xRegression doctests added for both cases.
Verified:
python3 -m doctest sorts/cyclic_sort.py -v— all 4 doctests pass.ruff checkpasses.