display: randomize PIN pad digits - #91
Closed
cofob wants to merge 1 commit into
Closed
Conversation
Owner
|
Already implemented in #93 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Randomize all ten digit positions on the PIN pad for each PIN request to reduce PIN recovery from observed tapping patterns and touch traces. Randomization is enabled by default, with a persistent Settings → Display → Random PIN pad option to disable it.
The existing
EF_DISPLAYrecord remains compatible by storing the fixed layout as an opt-out flag. Fixes #90.How it was tested
nix develop -c ./scripts/check.shpasses locallyChecklist
config.device_releasebumped from0x095Bto0x095Cunsafe→ N/A; nonedocs/guides/display.mdand screenshots updateddisplay: randomize PIN pad digits