Skip to content

RES-1863: draggable map for group location fine-tuning - #895

Open
edwh wants to merge 1 commit into
developfrom
RES-1863-draggable-map-v2
Open

RES-1863: draggable map for group location fine-tuning#895
edwh wants to merge 1 commit into
developfrom
RES-1863-draggable-map-v2

Conversation

@edwh

@edwh edwh commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Re-implements #637 (RES-1863, draggable map for group create/edit) from scratch on the current codebase. The old branch was 1,240 commits behind and conflicted with the build system; it also bundled the Mapbox geocoder switch, which belongs to RES-1858 (#644) and is deliberately not included here.

Since #637 was written, develop gained a static GroupLocationMap preview and Google Places autocomplete, so this PR is much smaller than the original:

  • GroupLocationMap becomes draggable: the marker is pinned to the map centre; dragging emits update:lat/update:lng. A fresh geocode from the location field still recentres the map, with an epsilon guard so the parent echoing a drag back down doesn't fight the user. A partials.dragmap hint invites the fine-tune.
  • GroupAddEdit syncs the dragged coordinates and includes lat/lng in the create/edit payloads (string-cast — the store's FormData builder drops falsy values, which would eat a 0 coordinate). The :id-based remount hack is removed; it would have destroyed the map on every drag.
  • API v2 POST /groups and PATCH /groups/{id} accept optional lat/lng (validated numeric, in range, both-or-neither), which take precedence over the server-side geocode of the location text. Country still comes from geocoding, or from the existing record when the location text is unchanged. With an explicit pin, an ungeocodable location string is no longer fatal — the pin wins and the country is left null.

Testing

  • New GroupLatLngOverrideTest (6 tests): client coordinates win on create and edit; geocode fallback unchanged without them; out-of-range rejected; ungeocodable-location-with-pin succeeds; unchanged-location edit keeps existing coords.
  • New GroupLocationMap.test.js (5 tests): drag emits updates, marker follows, external geocode recentres, echo-guard, hint text.
  • Full Groups suite green (88 tests / 974 assertions); full Jest suite green (30 tests); translations check green (key added to en/fr/fr-BE only, per repo convention).

Re-implements the intent of the stale RES-1862_draggable_map branch on
the current codebase (which already gained a static location map and
Places autocomplete since that branch was written). The Mapbox geocoder
switch bundled into the old branch is deliberately NOT included - that
is RES-1858's concern.

- GroupLocationMap becomes draggable: the marker is pinned to the map
  centre, dragging emits update:lat/update:lng, and a fresh geocode from
  the location field still recentres the map (with an epsilon guard so
  the parent echoing our own drag back down doesn't fight the user)
- GroupAddEdit syncs the dragged coordinates and sends lat/lng with
  create/edit; the :id remount hack is gone (it would have destroyed and
  recreated the map on every drag)
- API v2 group create/update accept optional lat/lng, which take
  precedence over the server-side geocode of the location text; country
  still comes from geocoding (or the existing record when the location
  text is unchanged). With an explicit pin, an ungeocodable location
  string is no longer fatal - the pin wins and country is left null
- New partials.dragmap hint (en/fr/fr-BE)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TzY1phBjyT3HogpeS53zon
@sonarqubecloud

Copy link
Copy Markdown

@edwh edwh added the preview Deploy a Fly.io preview for this PR label Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Preview: https://restarters-pr-895.fly.dev

✅ Ready - restore and migrations succeeded.

  • Branch is 26 commit(s) behind develop (0 touching migrations); the preview is built from the merge with current develop.

  • Password-protected test environment (usual dev gate password); commit 12f61c9953f81bece8f38526635756fdd4e39383 merged with develop.

  • If you see a "warming up" page, give it a few minutes - it refreshes itself.

  • The preview database is refreshed on every deploy and may reset at any time; anything you create here is disposable.

  • Emails go to shared Mailpit, never to real recipients. Image uploads are disabled.

  • The app suspends when idle; the first request after a pause can take a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Deploy a Fly.io preview for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant