unify(commandline): Move CommandLine to Core

[Jaredl-Dev]

• Merge after chore: Correct the game title in Copyright headers of CommandLine source files #3042

This moves CommandLine.h and CommandLine.cpp, shared by Generals and Zero Hour, into Core.

Both files are byte-identical between the two games.

Verification

• Verified both complete files are byte-identical between Generals and Zero Hour
• cmake --workflow --preset vc6
• cmake --workflow --preset win32

[greptile-apps]

Greptile Summary

The PR consolidates the byte-identical Generals and Zero Hour command-line implementation into the shared Core GameEngine source set.

• Moves CommandLine.h and CommandLine.cpp from the Generals tree into Core.
• Removes both game-specific source-list entries and the duplicate Zero Hour files.
• Records the completed move in the unification helper script.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains in the eligible follow-up review scope.

Important Files Changed

Filename	Overview
Core/GameEngine/CMakeLists.txt	Registers the unified command-line header and implementation in the shared GameEngine interface source set.
Core/GameEngine/Include/Common/CommandLine.h	Relocates the unchanged command-line interface into Core.
Core/GameEngine/Source/Common/CommandLine.cpp	Relocates the unchanged command-line implementation so each game target compiles the shared source.
Generals/Code/GameEngine/CMakeLists.txt	Removes the Generals-local command-line files from its source list in favor of Core.
GeneralsMD/Code/GameEngine/CMakeLists.txt	Removes the Zero Hour-local command-line files from its source list in favor of Core.
scripts/cpp/unify_move_files.py	Documents the completed unification operations as disabled helper calls.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    Core["Core CommandLine sources"]
    Generals["Generals GameEngine target"]
    ZeroHour["Zero Hour GameEngine target"]
    Core --> Generals
    Core --> ZeroHour

Loading

_{Reviews (2): Last reviewed commit: "unify(commandline): Move CommandLine to ..." | Re-trigger Greptile}

[Skyaero42]

Validated with winmerge that these commandline is indeed equal in both games.

[xezon]

This change moves Generals to Core. It should always move GeneralsMD to Core. It looks like the error is that Generals has a Zero Hour header.

[Jaredl-Dev]

This change moves Generals to Core. It should always move GeneralsMD to Core. It looks like the error is that Generals has a Zero Hour header.

The script did move the GeneralsMD files, but GitHub matched the identical Generals files instead. I’ll fix the incorrect Generals banner in a separate PR, then rebase this one once it’s merged. Should the unify script be updated to account for byte-identical files like this? I could add a small warning to it to help avoid instances like this?

[xezon]

Yes you can do that if you like.

Edit: Maybe is not needed. CommandLine files were the only offender.

[Jaredl-Dev]

Yes you can do that if you like.

Edit: Maybe is not needed. CommandLine files were the only offender.

I have updated this pull request.