Skip to content

unify(precompiled): Move Precompiled to Core - #3050

Merged
xezon merged 2 commits into
TheSuperHackers:mainfrom
Jaredl-Dev:unify/gameengine-precompiled
Aug 2, 2026
Merged

unify(precompiled): Move Precompiled to Core#3050
xezon merged 2 commits into
TheSuperHackers:mainfrom
Jaredl-Dev:unify/gameengine-precompiled

Conversation

@Jaredl-Dev

Copy link
Copy Markdown

This moves the shared Precompiled files into Core:

  • PreRTS.h
  • PreRTS.cpp

Generals now receives Zero Hour's required ObjectStatusTypes.h dependency before the unified files are moved. The Core include directory is exported so existing bare #include PreRTS.h directives continue to resolve for both games.

Verification

  • Verified both moved Core files exactly match their pre-move Zero Hour copies.
  • Win32 Release build succeeds.
  • VC6 Release build succeeds.

@Jaredl-Dev
Jaredl-Dev marked this pull request as ready for review August 2, 2026 15:30

@Skyaero42 Skyaero42 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with Winmerge

Note: commit 2 (move) and 3 (add include directory) may need to be squashed.

@Jaredl-Dev
Jaredl-Dev force-pushed the unify/gameengine-precompiled branch from cc02e6e to 226df7d Compare August 2, 2026 18:35
@Jaredl-Dev

Copy link
Copy Markdown
Author

Verified with Winmerge

Note: commit 2 (move) and 3 (add include directory) may need to be squashed.

Commits 2 and 3 have been squashed.

@xezon xezon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs pull id's in commit titles.

@xezon xezon added Gen Relates to Generals ZH Relates to Zero Hour Unify Unifies code between Generals and Zero Hour labels Aug 2, 2026
@Jaredl-Dev
Jaredl-Dev force-pushed the unify/gameengine-precompiled branch from 226df7d to 2311f10 Compare August 2, 2026 19:49
@Jaredl-Dev

Copy link
Copy Markdown
Author

Needs pull id's in commit titles.

Done

@xezon
xezon merged commit c95cf1c into TheSuperHackers:main Aug 2, 2026
16 checks passed
@Jaredl-Dev
Jaredl-Dev deleted the unify/gameengine-precompiled branch August 2, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gen Relates to Generals Unify Unifies code between Generals and Zero Hour ZH Relates to Zero Hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants