feat(memory): brainId, subjectId, and predicate facets on admin.list - #23
Open
rrader26 wants to merge 1 commit into
Open
feat(memory): brainId, subjectId, and predicate facets on admin.list#23rrader26 wants to merge 1 commit into
rrader26 wants to merge 1 commit into
Conversation
The server's admin list route already accepts all three, and `list` passes params straight through as query — so they worked at runtime and were simply missing from ListMemoryParams, which meant TypeScript callers had to cast to reach them. brainId is a real server-side filter, unlike the knowledge graph, which stays workspace-wide because entities dedupe across brains. The doc comment says so, since the asymmetry is surprising.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #21/#22, found while building the brain-scoped memory view
in the
chat-with-memoryexample.GET /admin/memoryacceptsbrainId,subjectId, andpredicate, and theSDK's
list()already forwards params verbatim as query string — so all threeworked at runtime. They were just absent from
ListMemoryParams, so aTypeScript caller had to cast to
Record<string, unknown>to pass them, whichis exactly the kind of thing an SDK exists to prevent.
brainIdgets a doc comment calling out the asymmetry that surprised me:it is a real server-side filter on memories, while the knowledge graph is
still workspace-wide because entities dedupe across brains. Anyone building a
per-brain view will hit that difference and should not have to discover it by
comparing two screens.
Type-only change — no runtime behaviour differs. Typecheck and build clean.