fix(release): cut Linux-only release - #11
Merged
Merged
Conversation
The Linux-only goreleaser fix landed in 67f010f as a build: commit, which release-please does not treat as releasable, so no new version was cut and the corrected release never ran. This empty fix: commit gives release-please a releasable change so it opens a release PR; merging it re-runs goreleaser with the Linux-only config and publishes the artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
67f010fas abuild(release):commit. release-please does not treatbuild:as releasable, so it cut no new version and the corrected goreleaser build never ran. The release is still effectively broken — the fix is onmasterbut unreleased.After
fix:commit exists, so release-please opens a release PR (patch →v0.2.1). Merging that release PR re-runs the goreleaser job with the Linux-only config and publishes the artifacts.Summary of changes
fix(release):commit to give release-please a releasable change67f010fFiles updated
Validation
goreleaser release --snapshot --clean(on the merged config)linux_amd64+linux_arm64; producesbackstage_Linux_x86_64.tar.gz,backstage_Linux_arm64.tar.gz,checksums.txtfix:bumps patch → opens release PR; merging it setsrelease_created=trueand runs goreleaserDeviations
master; only a releasable commit type is needed to trigger the release.Risks / follow-ups
fix:/feat:(notbuild:) when the release itself must be cut.References
fix/trigger-linux-release