feat: live transitions in prompter style with interrupt-safe recording - #8
Merged
Merged
Conversation
Cover the new live-transition steps, prompter popup style fields, and interrupt-safe recording behaviour in the configuration, how-it-works, and scenes guides.
Add Hypr-overlay live transitions wired through scene validation, the engine step loop, and multi-scene production stitching. Rework the prompter popup (style, header, class) and make recording interrupt-safe via a command guard that cannot kill a half-spawned process group and an interrupt guard that runs cleanup exactly once. Harden scene path resolution to canonicalize symlink-resolved paths and reject root escapes. Single increment: the supporting subsystems share test files, so they ship together rather than as separate intent commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After
Summary of changes
command_guard.go+interrupt.go: guard holds the mutex acrosscmd.Start(); cleanup runs once, bounded by a timeoutSafePathreturns the canonical symlink-resolved path instead of rawabsFiles updated
internal/engine/(engine.go,actions.go,command_guard.go,interrupt.go+ tests)internal/transition/transition.gointernal/production/production.gointernal/prompter/(hypr_popup.go,prompter.go)internal/recorder/gpu.gointernal/scene/(loader.go,paths.go,types.go,validate.go)internal/cli/cli.go.docs/(configuration, how-it-works, scenes)Validation
go build ./...go vet ./...go test ./...go test -race(engine/scene/prompter)Deviations
featcommiterrors.Join+ stderrRisks / follow-ups
SafePathTOCTOU hardening assumes a single-operator trust model; revisit if scenes ever come from untrusted sources.safeNameREinvariant — any future placeholder sourced from a non-validated field would reintroduce injection risk.References
4694a4e,7833589feat/live-transitions-prompter-style