Repository navigation
Conversation
Avoid caching incomplete lookups when the request context is canceled, and perform asynchronous cache writes with an independent three-second timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GetTierByGuildandGetTierByUserWithSourcecache their result in Redis from a goroutine that used the caller's ctx. Callers such as the worker's message listener cancel that ctx as soon as the lookup returns, so the write usually failed withcontext canceledbefore reaching Redis and results from those lookups were rarely cached.cacheTierhelper with its owncontext.Background()and a 3s timeout, likeworkflowbus/producer.go.ListGuildSubscriptions/ListUserSubscriptionsdon't checkrows.Err(), so a query cut short by ctx returns no rows and no error, which would cache a falseNonefor 5 min.Side effect: these lookups now fill the 5-min cache too, so a new purchase can take up to 5 min longer to be picked up.
Takes effect once worker and dashboard bump common.
Type of Change
Checklist