Repository navigation
Conversation
Avoids accessing a destroyed editor while synchronizing external Markdown value changes, preventing errors during editor teardown.
BenHall-1
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RM-343
Description
Fixes a crash when reloading the Create KB article page:
TypeError: Cannot read properties of undefined (reading 'getMarkdown').On a hard reload, React holds back showing the lazy-loaded page (up to 300 ms after the loading fallback). Tiptap's
useEditordestroys the editor it created during render if the component hasn't mounted within 1 ms, anddestroy()clearseditor.storage.MarkdownEditor's value-sync effect then readstorage.markdownon that destroyed editor and threw.Type of Change
Testing
Checklist