Skip to content

RM-344: Fix claim restoring the previous panel's team access after /switchpanel - #159

Open
biast12 wants to merge 1 commit into
masterfrom
RM-344
Open

biast12 wants to merge 1 commit into
masterfrom
RM-344

Conversation

@biast12

@biast12 biast12 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

RM-344

Description

Claiming on a panel with Support can view and Support can type enabled sent the channel's full permission overwrite list, read from the channel cache, with the claimer added. Right after /switchpanel that cache can still hold the previous panel's overwrites, so the claim gave the old panel's team access again and removed the new panel's team.

The claim now sets only the claimer's overwrite (EditChannelPermissions) and leaves every other overwrite untouched. It also skips the rename when the claimed name is the same as the unclaimed name. This covers /claim, the claim button, /transfer and dashboard claims.

Type of Change

  • Bug fix
  • New feature
  • Breaking change

Testing

  • two teams-only panels, panel B with Support can view + Support can type; open a ticket in A → /switchpanel to B → /claim → Team B keeps access, Team A has none

Checklist

  • My code follows the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Update the claimer's channel permission overwrite through the dedicated permissions API, preserving audit context and avoiding unnecessary channel modifications when only permissions change or no update is needed.
@biast12
biast12 requested a review from a team as a code owner October 5, 2026 18:41
@github-actions github-actions Bot added the type:bug Bug Fixes label Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant