Repository navigation
Conversation
Update the claimer's channel permission overwrite through the dedicated permissions API, preserving audit context and avoiding unnecessary channel modifications when only permissions change or no update is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RM-344
Description
Claiming on a panel with Support can view and Support can type enabled sent the channel's full permission overwrite list, read from the channel cache, with the claimer added. Right after
/switchpanelthat cache can still hold the previous panel's overwrites, so the claim gave the old panel's team access again and removed the new panel's team.The claim now sets only the claimer's overwrite (
EditChannelPermissions) and leaves every other overwrite untouched. It also skips the rename when the claimed name is the same as the unclaimed name. This covers/claim, the claim button,/transferand dashboard claims.Type of Change
Testing
/switchpanelto B →/claim→ Team B keeps access, Team A has noneChecklist