[biast12]

RM-348

Description

Colours are *int throughout: nil sends no colour (Discord's default bar), and 0 sends black.

• Guild colours: GetColours, GetColourOrDefault, GetColourForGuild and Replyable.GetColour return *int, and a NULL custom colour means no colour. Default colour maps are copied instead of shared.
• BuildEmbed / BuildEmbedRaw, welcome and tag embeds, form answers, /switchpanel, the close embed, /setup, help and the exit survey all send the colour through SetColorPtr.
• Containers send the guild colour as accent_color, so no colour gives Discord's default bar instead of a black one.
• Out-of-hours uses the stored colour as is (NULL = no colour, 0 = black). Panels without settings still use the guild Failure colour.
• Removed the unused customisation.GetColour.

Needs:
TicketsBot-cloud/gdl#19
TicketsBot-cloud/database#49

Type of Change

• Bug fix
• New feature
• Breaking change
• Improvement

Testing

• Captured the real Discord payloads against Postgres: nil leaves out color / accent_color, and 0 sends "color":0.

Checklist

• My code follows the style of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[github-actions]

Resolved

No blocking labels remain.

[BenHall-1]

Ready for merge on db & gdl and bump :)