Skip to content

docs: file P58-P60, R14, T19 from the qualified quoted column work - #98

Open
TimelordUK wants to merge 1 commit into
mainfrom
fix/qualified-quoted-columns
Open

TimelordUK wants to merge 1 commit into
mainfrom
fix/qualified-quoted-columns

Conversation

@TimelordUK

Copy link
Copy Markdown
Owner
  • P58: alias."quoted col" - expression positions fixed on this branch; JOIN ON keys still fail (hash join re-splits the flattened name at the last dot).
  • P59: quoted table alias ("l".col, FROM t "l") not accepted.
  • P60: GROUP BY an unknown column silently forms one NULL group (group_by_expressions.rs unwrap_or(Null)).
  • R14: column references resolved by several hand-written copies; inventory, target shape and slices, sequenced after R13.
  • T19: completion does not know table aliases (l. offers methods).

DuckDB 1.5.5 answers checked by hand against data/countries.csv.

- P58: alias."quoted col" - expression positions fixed on this branch;
  JOIN ON keys still fail (hash join re-splits the flattened name at the
  last dot).
- P59: quoted table alias ("l".col, FROM t "l") not accepted.
- P60: GROUP BY an unknown column silently forms one NULL group
  (group_by_expressions.rs unwrap_or(Null)).
- R14: column references resolved by several hand-written copies;
  inventory, target shape and slices, sequenced after R13.
- T19: completion does not know table aliases (l.<tab> offers methods).

DuckDB 1.5.5 answers checked by hand against data/countries.csv.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
IgorOffline pushed a commit to IgorOffline/TimelordUK-sql-cli that referenced this pull request Oct 10, 2026
clippy 1.99 (CI) denies the literal under approx_constant and points at
f64::consts::GOLDEN_RATIO, which the 1.98 toolchain lacks. Computing
(1 + sqrt 5) / 2 compiles on both and gives the same f64,
1.618033988749895. Broke the Complete Test Suite on PR TimelordUK#98.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant