Installer localization system refactor and expansion to support more languages and improve maintainability.#136
Merged
Merged
Conversation
Standardize layout and format of the localization file to be consistent with other TImthreetwelve apps. TimVerEx.iss renamed to TimVer.iss. TImVerLocalization.iss renamed to TimVer.localization.iss. Additional cleanup of MyScheduledTasks.iss
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Inno Setup installer localization by replacing the old localization include with a new, more structured localization file, expanding supported installer languages, and updating the installer script to use standardized message keys and revised version-info handling.
Changes:
- Replaced
TimVerLocalization.isswith a new structuredTimVer.localization.issand expanded language support (ca, de, fr, pt, sk). - Updated
TimVer.issto include the new localization file, switch to the newDeleteConfigFilesmessage key, and adjust welcome/uninstall logic. - Added a new framework-dependent x64 publish profile (
Framework_Dependent_x64.pubxml) alongside the existing self-contained profile.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TimVer/Properties/PublishProfiles/Framework_Dependent_x64.pubxml | Adds a framework-dependent x64 publish profile for producing installer inputs. |
| TimVer/Inno_Setup/TimVerLocalization.iss | Removes the old localization include file (replaced by the new structured localization file). |
| TimVer/Inno_Setup/TimVer.localization.iss | Introduces the new consolidated localization file with additional languages and standardized keys. |
| TimVer/Inno_Setup/TimVer.iss | Switches to the new localization include, updates message keys, and adjusts version info + uninstall cleanup behavior. |
Comments suppressed due to low confidence (2)
TimVer/Inno_Setup/TimVer.iss:77
VersionInfoVersionwas changed to use{#MyInfoVersion}, butMyInfoVersionis not defined anywhere in the repository (only referenced). Unless the generatedPubSetup.Temp.issalways defines it, the installer script will fail to preprocess/compile.
TimVer/Inno_Setup/TimVer.iss:219- The uninstall prompt says it will remove settings/history files, but the code deletes the entire
{app}directory (DelTree('{app}', True, True, True)), which can remove any user-added files left in the install folder. Consider deleting only the known config/history files (e.g.,usersettings.jsonandhistory.json) and keep the install folder cleanup to the normal uninstaller behavior. Also, the Run value name is hardcoded as 'TimVer' instead of using{#MyAppName}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installer localization was restructured with a new, comprehensive localization file, expanded language support, and improved version info handling. Key message keys were standardized and the installer script was updated accordingly.
TimVerLocalization.issand addedTimVer.localization.isswith clearer structure and support for Catalan, German, French, Portuguese, and Slovak.TimVer.issto use the new localization file, standardized message keys, and improved version info logic withMyInfoVersion.