Skip to content

fix: correct assistant lock order and release validation inputs - #10

Draft
LIghtJUNction wants to merge 12 commits into
mainfrom
review/release-fixture-contracts-20261120
Draft

LIghtJUNction wants to merge 12 commits into
mainfrom
review/release-fixture-contracts-20261120

Conversation

@LIghtJUNction

@LIghtJUNction LIghtJUNction commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Current status

Draft: the original bbf72df7 Identity gate failed; this PR is not fully qualified. All three original attempt 1 runs are terminal. Their actual checkout is 95feb5dd5c7775070de0b11d2b8ae0c4289294f7, binding head bbf72df77a6c144462fc17976a586b4ea4d5b51b and base 65c7c5c644646535054f82bde2ec291526a53d0b.

Original gate Verified terminal result
CI — 44724871920 Success. Original Core, payment, Go, Store, RPC and aggregate checks passed; terminal source and evidence were independently verified.
Identity — 44724872007 Failure. APP07, completion upgrade and navigation upgrade each returned UPGRADE_DB_OTHER_CLIENT_OR_PREPARED_TRANSACTION. The original A5 kill/restart and store-tristate cases both passed.
Native — 44724871959 Success. Both original architecture jobs passed.

The Identity log records lib 1,829 passed / 1 failed / 33 ignored, completion upgrade 1 passed / 1 failed, and navigation upgrade 1 passed / 1 failed. It does not identify the conflicting backend/prepared transaction or each exact historical rejection stage. Unrelated autovacuum messages do not establish causation. All original logs and failures remain preserved; no original run was rerun or cancelled manually.

The later three-case diagnostic, control af783312 and product 37649a1a, executed each original APP07/completion/navigation case once with 1 PASS / 0 FAIL / 0 ignored. It retained the business assertions and production guard, and checked source stability and disposable PostgreSQL cleanup. This is targeted evidence on that separate source, not a replacement for this failed full Identity gate. The first diagnostic's missing private evidence environment failure remains preserved.

The ongoing feature/8e candidate and plugin release work has a separate source lineage and qualification. See the current iteration record. Its component78 and four-case results do not authorize merging or deploying this main/cf candidate.

The release owner's production migration and activation remain blocked by the required real source approvals and financial declarations. This PR has not switched a production service, database or entry point. Terminal evidence was collected by 13:09 UTC; this status correction records those already verified outcomes without starting new jobs.

Why this is needed

The assistant cancellation recovery path had a real lock-order defect. The worker acquired a charging row before the conversation lock, while status polling took the opposite order. PostgreSQL detected a deadlock, and the worker ignored the failed classification transaction, leaving the request in streaming.

The original release checks also exposed missing fixture inputs, evidence ownership errors and snapshot baselines taken before asynchronous performance observations completed. Each correction keeps the existing business assertions and resource budgets.

Changes

  • Acquire the existing conversation lock before classifying an unfinished assistant charge as UNKNOWN, and propagate classification and commit errors. Preserve the cancellation test and add a real PostgreSQL lock-order regression with unchanged reservation and single-dispatch checks (78cb1555).
  • Observe the installed executable under its actual service UID/GID (508e66ed). Hand back only the three private Native evidence files to the runner before upload, preserving permissions and rejecting symlinks or non-regular files (1c1582cf).
  • Restore Identity's existing preserved executors, acquisition/private-evidence prerequisites and mandatory payment owning runner (73c01b4d).
  • Add actual-Result diagnostics to the existing APP05 and managed70 rejection assertions without changing their single calls or expected errors (7b0832d3, c3a38f17).
  • Synchronize the already-pinned purego version and its two existing checksums into the isolated Store pgtest module (e0befd48).
  • Initialize the pinned Extore submodule and freeze the RPC fixture's actual Docker COPY inputs (d92c9af7). Update the exact required-submodule expectation while preserving strict equality and anti-recursion checks (6a0a0f4f).
  • Wait for the successful root request's existing performance observation before taking the A5 restart baseline (fe6b6ff1). Keep the real SIGKILL, same-database restart, same-nonce HTTP 409, full snapshot, provider count and balance assertions.
  • Apply the same existing completion prerequisite after each of the six successful default/store-policy combinations in the store-tristate test (bbf72df7). Reuse the read-only performance_sample helper and its original 3-second bound. Keep every rejection, full snapshot, usage count, funding and provider assertion, and the existing stateless completion barrier.

The last two changes affect tests only. The production response completes independently of its spawned performance-recording transaction; reading the body or observing settled request state does not join that transaction. This establishes a missing baseline prerequisite in the test source. It does not identify the extra historical usage-event row.

Latest completed candidate: fe6

All three original runs for head fe6b6ff1, base 65c7c5c6 and actual merge checkout d4c70abe6a9f576f4b46448018315f456751529e are terminal. Their original logs and failures are preserved.

  • CI passed. Core lib: 1,830 passed, 0 failed, 33 ignored; assistant: 13/13; navigation upgrade: 2/2. The A5 and store-tristate cases both passed in this job. The original payment owning runner, Go race tests, Store real PostgreSQL, durable-event recovery, native protobuf/failure recovery and final quality gate passed.
  • RPC evidence was verified beyond the green step. The actual 36,848,434-byte artifact matched GitHub's SHA-256. It records 77 schema components, 289 commands and successful business assertions for install/repeat-init rejection, runtime privileges, native teams, protobuf, restart/replacement, service-token rejection, revocation, token rotation and bounded database outage/reconnect. Owned-runtime cleanup passed with no cleanup errors. All 1,810 source files present in the archive matched the 1,811-entry binding; the hidden .dockerignore input is absent from the archive and its declared digest remains recorded. The exact fixture script matched the immutable d4c70abe source. No claim is made that all 1,811 input bytes were archived.
  • Native passed. Both complete logs verify checkout d4c70abe and successful original build, install/upgrade, real Alpine catalog, evidence handoff and upload steps. Large package ZIPs have API metadata only; their contents were not downloaded for this observation.
  • Identity failed. The sole failed lib case was responses_continuity_independent_store_tristate_and_exact_refusal, at source line 1349. Its full-snapshot comparison observed usage count 32 → 33; the other recorded snapshot fields matched. Lib: 1,829 passed, 1 failed, 33 ignored. Assistant 13/13 and navigation upgrade 2/2 passed. The complete raw log is retained. The additional event's identity is unknown; neither the passing Core job nor the new prerequisite retroactively explains that row.

The fe6 Identity failure blocks qualification of that candidate. The new bbf results above must stand on their own.

Earlier evidence retained

  • Lock-order control: the old-product negative control ran the exact new regression and produced its specific lock-cycle assertion plus an actual PostgreSQL deadlock. The fixed 78 product passed all 13 assistant cases and the exact APP05 case, with zero ignored. Product/control sources, test counts and artifact digests were independently bound.
  • Native ownership: the original dual-architecture workflow at 1c passed the actual catalog, evidence handoff and upload.
  • Managed70: the exact original case at c3 passed 1/1, zero ignored, in 6.33 seconds. That pass does not establish the cause of the earlier failure whose actual Result was absent.
  • Bounded continuity diagnostics: the original four-case control at product 22c passed exact A5, store-tristate and two native performance cases, each selected and executed once with zero ignored. The control was 37258249; product 22c5a510, unchanged source inputs, Rust 1.100 and PostgreSQL 18.6 were verified. This is targeted evidence, not a substitute for the failed fe6 Identity run or the new complete gates.
  • Original 73 failures: CI passed its Rust real-database, payment, Go race and durable-event steps, but Store stopped at the missing purego checksum and RPC at missing formal image inputs before their business assertions. Identity retained its managed70 lib failure. Native retained the upload EACCES failure. These are not rewritten as passes.
  • Combined d92: the Native run rejected the outdated required-submodule expectation. The correction passed the original topology suite, 19/19 with zero skipped. CI was automatically superseded/cancelled; unfinished checks are not passes. Its Identity run naturally failed only the navigation-upgrade target with UPGRADE_DB_OTHER_CLIENT_OR_PREPARED_TRANSACTION; the specific client/prepared transaction remains unestablished.
  • 6a: CI and Native passed on actual checkout be7e13aa. Identity failed the A5 kill/restart snapshot with usage 4 → 5, while the other recorded fields matched. The full log and actual artifact remain preserved; the fifth event is still unidentified. That is distinct from d92's navigation rejection and fe6's store-tristate failure.

Source and release boundary

This PR stays on the release owner's 65/cf lineage, with Extore pinned to cf3469dbe827afcfb2e3f054a63f7b9b7c40bc2b. It does not import the separate shared-state host ABI.

The separate 8e feature evidence remains bound to its own sources: 6102f997 has verified official packages and an actual 14-check short browser pass; the 22c5a510 package comparison preserves that browser source distinction. Its original complete feature CI subsequently passed on 22c. The earlier c430 formatting failure is retained. Those results do not qualify this PR's different Go/native ABI.

Diagnostic control commits remain on their own branch. Production migration, activation and any release-owner approval remain separate blocked work; no deployment success is claimed here.

The Alpine smoke probe reaches a healthy installed service, then fails when the container-root observer reads the other UID's procfs executable link.
Run that exact read as the existing service UID and GID with no supplementary groups. Keep the executable-path assertion, timeout, error propagation and subsequent native catalogue checks.
The Identity workflow invokes all Core targets without the private evidence roots, acquisition fixtures, pinned historical objects or preserved executors required by those tests.
Reuse the established Core protocol setup and retain every test assertion. Execute the payment-live case through its mandatory owning runner, which validates the real parent PID and the exact passing test result.
Preserve the job timeout, resource configuration, failure propagation and original failed-run evidence.
@LIghtJUNction LIghtJUNction changed the title fix: satisfy installed-package and Identity test prerequisites fix: correct assistant lock order and release validation inputs Nov 20, 2026
LIghtJUNction and others added 4 commits November 20, 2026 14:46
The original full Identity run observed a global usage-count change from32 to33 in the store-tristate refusal test. Each earlier successful response can finish before its detached performance write completes.

Wait for the existing bounded, request-specific performance sample after each successful stored request and before taking later refusal baselines. Keep every original snapshot, balance, provider-call, and refusal assertion unchanged. The historical extra event's identity remains unknown; its original failure evidence is retained.

[skip ci]
@LIghtJUNction
LIghtJUNction force-pushed the review/release-fixture-contracts-20261120 branch from bbf72df to fe7f291 Compare November 20, 2026 17:57

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants