Repository navigation
Test wallet plan retries while reset vouchers are loading - #14
Draft
LIghtJUNction wants to merge 1 commit into
Draft
LIghtJUNction wants to merge 1 commit into
LIghtJUNction wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wallet disclosure on main contains two independently loaded views. A failed plans request can show its local error and Retry button while the banked reset voucher request still shows Loading. The previous assertion scanned the whole disclosure. The failing Web job tested merge commit
07573d0fb2e20bc953dc1ba0f67cbadd32827986and showed both states in the same string.The test holds the synthetic reset voucher request pending through the plan error and retry. It checks the plan error, Retry button and confirmed empty results within the subscriptions card. It separately checks the voucher loading status, releases that request, and waits for the voucher empty state. The request counts cover both plan reads before and after retry and the single voucher read.
On base
1f8566fcd132fe2c9c448400cc078d3edbab12fc, holding the voucher pending reproduced the original assertion failure. With the change, the targeted test passed five consecutive fresh Bun processes, all 12 tests in the wallet file passed, and the Web TypeScript build and file formatting check passed. Tests used Bun 1.3.14 and synthetic responses.The hosted Web checks and production build passed on
dad5c195f591beeafce8246d1a300698a248ad7f. The wallet regression passed, and the serial Web suite completed all 765 source test files and 6 script test files.