Repository navigation
fix(ci): launch npm portably on Windows - #1
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
|
Local validation on 2026-11-20 (UTC) against current remote |
Problem
The Windows
latestmatrix job fails intest:integrationat the host SDK dependency installation stage:The script invokes
npmdirectly throughexecFileSync. On Windows, npm is exposed through a command shim rather than a directly executablenpmbinary.Change
Run the current npm CLI with
process.execPathand thenpm_execpathsupplied by the surroundingnpm runprocess. This avoids shell-dependent command resolution and keeps the exact npm installation already selected by the workflow.The script now also fails explicitly if it is invoked outside the required npm-script context.
Validation
npm ci --ignore-scriptsnpm run build && git diff --exit-code -- distnpm run typechecknpm test— 45 passednpm run pack:checkOPENCODE_BIN=... npm run test:hostOPENCODE_BIN=... npm run test:integration— all three protocol refusal checks, expired-credential checks, and native CLI PKCE reconnect passedgit diff --checkRisk
Low. The change is limited to test dependency bootstrapping. It does not alter the plugin runtime, authentication behavior, credentials, or production package output.