feat: option to default to NLP for english recipes - #1133
Open
wh1t3-w0lf wants to merge 1 commit into
Open
wh1t3-w0lf wants to merge 1 commit into
wh1t3-w0lf wants to merge 1 commit into
Conversation
…ven if a LLM is available
wh1t3-w0lf
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the env variable NLP_IF_EN to default to NLP for ingredient parsing even if an LLM is available because I want the option to use the LLM only in the cases where it is necessary.
As mentioned in the comments, this does not guarantee finding the correct language because the scrapers language parsing uses website metadata and not the recipe text to determine the language, but it should match for most cases. If no language metadata is found, the default case is to use the LLM.