Conversation
Adds an opt-in setting that shows a leading checkbox on each shopping list row when list view is enabled. Tapping the checkbox removes the item (same optimistic remove as tap-to-remove); tapping the row opens the item page, matching the existing long-press behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an opt-in Checkboxes in list view setting (Settings → Shopping list section, only visible when list view is enabled).
Why
Tap-to-remove makes removing fast but hides item details behind a long-press, which is hard to discover. This mode gives both affordances distinct, visible targets: checkbox to check off, row to inspect.
Implementation notes
shoppingListCheckboxModepreference (SettingsCubit/SettingsState), defaultfalse— no behavior change unless enabled.SelectableButtonListTilegainsonCheckboxPressed; when set, the leading slot renders an uncheckedCheckbox. Confirm-mode's selected check icon still takes precedence.ShoppingItemWidget→SliverItemGridList→SliverCategoryItemGridList→SliverShopinglistItemView; only wired in the shopping list page.onPressedfallback inSliverItemGridList(the same path a long-press uses), so no duplicated navigation logic.app_en.arbonly ( untranslated-key placeholders: en ).Testing
flutter analyze— no new issues (2 pre-existing warnings in untouched files)flutter test— all 16 tests pass