Conversation
Bnyro
force-pushed
the
import-recipe-image
branch
from
September 2, 2026 18:00
44fccc1 to
1225f32
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, first of all, thanks for working on this app! We've been using it for 3 years now and it's really a lifesaver :)
I noticed that adding recipes fails if the image URL is a relative path. E.g., the
thumbnailUrlfield of https://schema.org/Recipe is just/example.jpginstead of a full URL. However, according to https://schema.org/url, URLs may be relative, so this is a bug in KitchenOwl that it can't handle relative URLs.To reproduce:
I additionally wrapped the image loading call into a
try exceptbecause I think that the recipe should still import fine even if the image can't be loaded (i.e. the image URL doesn't resolve). Might be good to show a warning to the user that the app failed to load the image, but I think that'd be too complex to implement.Cheers