Repository navigation
fix(chain-submitter): bound Soroban RPC calls with a configurable timeout - #27
Open
jeffrey-graham wants to merge 1 commit into
Open
jeffrey-graham wants to merge 1 commit into
jeffrey-graham wants to merge 1 commit into
Conversation
jeffrey-graham
force-pushed
the
fix-chain-submitter-rpc-timeout-22
branch
from
November 12, 2026 13:11
ce3d13f to
b032bd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
timeoutMs, defaulting toDEFAULT_RPC_TIMEOUT_MS = 15_000) toSorobanRpcSubmitterinsrc/integrations/chain-submitter.tsthat bounds bothsubmit()(getNetwork+sendTransaction) andstatus()(getTransaction), and wiresSTELLAR_RPC_TIMEOUT_MSinsrc/main.ts/.env.example(rejecting non-positive or non-finite values at construction).Errorwhen the Soroban RPC server does not respond withintimeoutMs, preserving theChainSubmittercontract where unknown network outcomes throw rather than returning{ accepted: false }or"FAILED".test/chain-submitter.test.tscovering invalidtimeoutMsrejection, fast RPCsubmit()/status()classification, never-resolvingrpc.Serverstubs on bothsubmit()(getNetworkandsendTransaction) andstatus(), andIntentServicekeeping timed-out intents inSUBMITTED->RECONCILING(neverFAILED) across initial and repeatedreconcile()ticks.Closes #22
Why this belongs in this repository
SorobanRpcSubmitterlives inTorrent-api(src/integrations/chain-submitter.ts) and drives transaction submission and status polling forIntentService.Other repo API/ABI impact
None —
openapi/openapi.v1.json,Torrent-webrequest/response contracts, and the Soroban escrow ABI are unchanged.Tests and evidence
GitHub Actions CI is awaiting maintainer workflow approval; ran the repository gates locally on Node 22.23.5:
npm run check(tsc --noEmit && eslint . && vitest run):17 passed (17)test files,117 passed | 1 skipped (118)tests (0typecheck or ESLint errors).npm run build(tsc -p tsconfig.build.json): passed (0errors).node scripts/check-docs.mjs:docs ok: 14 markdown files, all required files present, no broken relative links.npm audit --omit=dev --audit-level=high:found 0 vulnerabilities.Security/privacy and Stellar impact
Prevents a hung Soroban RPC endpoint from blocking
IntentService.submit()indefinitely or stalling thereconcile()loop across pending intents, while never misclassifying an RPC timeout as a definitive on-chain rejection (accepted: false/FAILED). No secrets, signing keys, or mainnet configuration are introduced.