Repository navigation
Conversation
|
@ZenAlexa is attempting to deploy a commit to the luokerenx4's Team Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Oct 1, 2026
ZenAlexa
marked this pull request as ready for review
October 1, 2026 22:46
# Conflicts: # ui/src/components/credentials/CredentialModal.tsx
Preserve merged model identity, interface profiles, and Inbox sender names. Keep pending save geometry and runtime selection semantics in shared controls. Retain route ownership for concurrent workspace and news contributions.
Retain the shared Dialog focus owner and the disabled-control regression from the workspace focus fix. Restore the bundled font used by launch labels.
Signed-off-by: ZenAlexa <zimingwang945@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The workspace needs consistent compact controls and stable geometry across navigation, settings, menus, and trading data. This shared-interface boundary addresses touching highlighted rows, disconnected Tools groups, oversized navigation, inconsistent select controls, and chart notices that move surrounding content.
Changes
Bundled Instrument Sans, explicit CJK fallbacks, and the existing Pretext launch-label measurement remain in place. Model identity, interface profiles, backend trading execution, order semantics, and provider routing retain their existing owners.
November 11 dev integration
Integrated
dev@4f06b8b2in5b123809. The compact inbox retains the unread-count and mark-all-read controls, including when no messages match. The model menu keeps search and free-form entry; unmatched text still offers the full provider list. Shared control guidance now lives in the architecture guide at its new upstream location.The three affected UI suites passed all 32 cases with
NODE_ENV=test, and the UI TypeScript build and production demo build passed. In Chrome, the demo rendered the inbox with its unread controls and the launch menu with the model and effort entries. These checks did not exercise live trading or deployment.November 1 dev integration
merged
devat006fffd5923fthrough a normal merge atfcd1a09c6ac5. the incoming changes bring the separate landing site into the workspace and keep its build outside the application and server build commands. all 252 contribution paths retain their pre-merge contents.the contribution whitespace check passed, and all 240 existing TypeScript/TSX files in the contribution parsed successfully. the existing confirmation test selector was invoked and executed zero checks because the local
vite-plusexecutable is unavailable. syntax parsing is the completed local check; dependency-aware type checks, the complete UI suite, browser interaction and visual checks, and native packaging remain unrun at this integration. the earlier results below retain their recorded revisions. please run current-head clean-build CI and the existing UI/browser checks.October 23 follow-up
The October 23 revision was based on
devat5da8dfcc. Removed the unusedConfirmDialogfallback-focus prop and its confirmation-state bookkeeping. All 14 production call sites use the connected-opener focus path; confirmation errors propagate, andfinallyclears the busy state. Removed an unusedmotion-spectrumpalette block and consolidated the suggestions guide around its existing stable-height, inert/aria-hidden behavior. Rendered styles, layout and trading behavior are unchanged.Revision
7bacdd72passed the three existingConfirmDialogchecks and a strict type check of the component's imported production closure in an isolated component setup using React 19.2.4, Base UI 1.6.0 and Vitest 5.0.1. An independent React/Base UI + JSDOM lifecycle scenario passed against both revisions: repeated Escape/return-focus, pending-action blocking, success with a connected or removed opener, and rejection followed by successful retry.These checks cover the shared confirmation component. The complete UI suite, production-browser visual and keyboard matrix, native windows, live brokers and packaged applications retain their historical or unrun status below. Please run current-head clean-build CI before merging.
October 13 dev validation
merged
5da8dfccand checked revision0345b656on 2026-10-13.the updated code passed ui and uta type checks, the production demo build, and 139 existing tests across 17 files. 18 snapshot scenarios covered exact source selection, carry-forward, records outside the recent window, deletion, duplicate timestamps, restart, and late replies. details now read the source used by the chart and stay closed when that source is missing or ambiguous.
the built image preview keeps its 10px radius. keyboard focus stays visible on checkboxes in forced colors. the skeleton uses the existing 1.6s duration and stops in reduced motion. connector fields retain 14px text at desktop and 390px widths.
the broader ui suite passed 2,084 tests before these final follow-up fixes. native windows chrome, live brokers, and signed packages were not exercised.
October 6 synchronization and compatibility
Merged
devat53baaa319and retained the model identity and interface profiles delivered by #1728 and #1729. Preserved the current Inbox sender names, Vite+ toolchain, dependency pins, and cadence editor behavior.Integrated #1648's disabled-control regression into the existing focus scenario. The shared Dialog owns focus containment; the replaced local focus trap stays removed.
Narrowed overlapping edits in the News collector, login screen, quote header, order-status badge, and application menu. Pairwise Git merge checks against 15 relevant open PR heads found zero additional conflict files and zero additional textual conflict hunks relative to current
dev:devbaseline.These checks cover pairwise textual integration at the sampled heads. Review shared primitives and tokens first, migrated consumers second, and account and chart behavior third.
Verification
Checked on October 6 against
devat53baaa319:NODE_ENV=test node scripts/run-tests.mjs --path ui/src).pnpm -F open-alice-ui build:demo).git diff --checkpassed.Browser scenarios used the production demo and its fixture data. Live broker execution, managed research processes, and native Electron packaging are outside this verification. The production build emits the existing large-chunk advisory.
October 6 screenshots
Captured from the final production-demo tree on October 6. The desktop viewport is 1280 × 800; the narrow viewport is 390 × 844. The runtime control retains visible keyboard focus after dialog dismissal.
For interactive review, navigate runtime choices with the keyboard, open the full runtime dialog, and dismiss it with Escape. Open workspace configuration, edit the name, save, and repeat after a failed request. Inspect toolbar wrapping at a narrow viewport and confirm that focus returns to the invoking control.