Repository navigation
fix(workspaces): shared start-leases, @new-then-resume rollback, and schedule marker serialization - #1829
Merged
Conversation
…en-resume, and serialize schedule markers
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acquireShared(workspaceId, operation)toWorkspaceOperationGuardfor process start-leases (headless-run,headless-probe,web-session-start,interactive-session-start) so same-tick scheduled runs or Telegram replies in the same Workspace do not collide on the ~60ms pre-spawn setup window (workspace is busy with headless-run), while directory-wide exclusive operations (template-upgrade,harness-source-upgrade,offboarding,absorb) remain mutually exclusive with all shared leases.@new-then-resumeIssueassigneewhen a birth run fails before capturing a native CLIagentSessionId, and allow resuming an existingresumeIdthat never capturedagentSessionIdto spawn fresh and bind the captured session ID instead of stranding the Issue innot_ready.ScheduleMarkerStore.flush()via a promise chain with unique${pid}.${seq}.tmpfiles so concurrent same-tick schedule updates never race onrename().Verification
npx tsc --noEmitpnpm test:changedpnpm exec vp test run --config vitest.integration.config.ts tests/integration/workspace-lifecycle/workspace-lifecycle.spec.ts tests/integration/workspace-assignee/service.issue-assignee-session.spec.ts