Skip to content

vulkan(replay): don't hard-fail on optional device features the replay GPU lacks #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
manon-traverse wants to merge 1 commit into
base: v1.x
Choose a base branch
from
Draft

vulkan(replay): don't hard-fail on optional device features the replay GPU lacks #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions renderdoc/driver/vulkan/wrappers/vk_device_funcs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2299,14 +2299,20 @@ bool WrappedVulkan::Serialise_vkCreateDevice(SerialiserType &ser, VkPhysicalDevi
VkPhysicalDeviceFeatures availFeatures = {0};
ObjDisp(physicalDevice)->GetPhysicalDeviceFeatures(Unwrap(physicalDevice), &availFeatures);

#define CHECK_PHYS_FEATURE(feature) \
if(enabledFeatures.feature && !availFeatures.feature) \
{ \
SET_ERROR_RESULT(m_FailedReplayResult, ResultCode::APIHardwareUnsupported, \
"Capture requires physical device feature '" #feature \
"' which is not supported\n\n%s", \
GetPhysDeviceCompatString(false, false).c_str()); \
return false; \
// If the replay device lacks a feature the capture enabled, don't hard-fail: strip the feature
// from the device creation and warn. This handles captures made with a newer/updatable driver
// (e.g. Adreno gpudrivers) replayed against a slightly different driver that doesn't advertise
// the same optional features. The frame usually doesn't actually exercise the stripped feature.
#define CHECK_PHYS_FEATURE(feature) \
if(enabledFeatures.feature && !availFeatures.feature) \
{ \
RDCWARN("Capture enabled physical device feature '" #feature \
"' not supported on the replay device - disabling it for replay."); \
enabledFeatures.feature = VK_FALSE; \
if(enabledFeatures2) \
enabledFeatures2->features.feature = VK_FALSE; \
if(createInfo.pEnabledFeatures) \
((VkPhysicalDeviceFeatures *)createInfo.pEnabledFeatures)->feature = VK_FALSE; \
}

CHECK_PHYS_FEATURE(robustBufferAccess);
Expand Down