Repository navigation
chore(consts): drop the unused node IP annotation name - #75
Merged
Merged
Conversation
Nothing reads robotlb/node-ip: node addresses come from the node status. A constant that looks like a supported annotation suggests a setting that does nothing. Assisted-by: LLM Signed-off-by: Aleksei Sviridkin <f@lex.la>
s3rius
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes a constant that nothing uses.
robotlb/node-ipis declared insrc/consts.rs, but robotlb takes node addresses from the node status (InternalIPorExternalIP). A constant named like a supported annotation suggests a setting that does nothing.No behaviour change. It merges cleanly with the open branches that also edit
src/consts.rs, and none of them use the constant.