chore(proto): stop generating Rust for in-design proto packages - #548
Open
yordis wants to merge 2 commits into
Open
chore(proto): stop generating Rust for in-design proto packages#548yordis wants to merge 2 commits into
yordis wants to merge 2 commits into
Conversation
The session and usage schemas are still being shaped, so binding them into the Rust workspace made a hand-written validation and codec layer track fields that keep moving, with no crate consuming it. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryMedium Risk Overview
Reviewed by Cursor Bugbot for commit 79e979f. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe change stops generating session and usage protobuf code, removes session support from ChangesSession proto removal
NATS timeout tests
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change stops generating Rust for in-design session and usage schemas while keeping schema validation checks in place; no actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Code Coverage SummaryDetailsDiff against mainResults for commit: 79e979f Minimum allowed coverage is ♻️ This comment has been updated with latest results |
The eviction path was only reached when the worker deadline happened to win a race against the HTTP request timeout, so coverage for it flapped between runs. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
added
the
rust:coverage-baseline-reset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The session and usage schemas are still in active design, but generating Rust for them tied the workspace to shapes that keep moving: a hand-written validation and codec layer had to be re-derived on every field rename, while no crate in the workspace enabled the features that consumed it. Excluding those packages from codegen lets the schema churn freely while
buf lint,format,build, andbreakingkeep covering them in full. ADR#0035 stays the source of truth for the session append-boundary rules, so the removed layer is recoverable once a consumer crate exists to justify it.Related