-
Notifications
You must be signed in to change notification settings - Fork 2
Better type inference for Query-based effects #96
Copy link
Copy link
Open
Labels
A-EffectsArea - concerning effect types.Area - concerning effect types.C-FeatureCategory - making something new possible.Category - making something new possible.D-ModestDifficulty - new features, refactors, and challenging bug fixes.Difficulty - new features, refactors, and challenging bug fixes.S-Ready-For-ImplementationStatus: this issue is ready for someone to pick it up and open a PR!Status: this issue is ready for someone to pick it up and open a PR!
Description
Activity
Metadata
Metadata
Assignees
Labels
A-EffectsArea - concerning effect types.Area - concerning effect types.C-FeatureCategory - making something new possible.Category - making something new possible.D-ModestDifficulty - new features, refactors, and challenging bug fixes.Difficulty - new features, refactors, and challenging bug fixes.S-Ready-For-ImplementationStatus: this issue is ready for someone to pick it up and open a PR!Status: this issue is ready for someone to pick it up and open a PR!
The Query-based effects like
ComponentsSet-andEntityComponentsSet-are very generic, allowing for filters and extra query data to be specified. However, actually using these features is somewhat annoying, requiring the user to specify them in the constructor call: https://github.com/Trouv/bevy_pipe_affect/blob/main/examples/sokoban/animate.rs#L13Even specifying them in the closure, a more readable option IMO, doesn't resolve the issue because of some lifetime difference between the outer generic and inner closure parameter.
This issue is for improving this situation... somehow. Need to look into it more for a proper recommendation.