Repository navigation
Write the benchmark report to a file instead of stdout - #1498
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1498 +/- ##
=======================================
Coverage 83.78% 83.78%
=======================================
Files 54 54
Lines 4651 4651
=======================================
Hits 3897 3897
Misses 754 754 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
DynamicPPL.jl documentation for PR #1498 is available at: |
Contributor
Benchmarks @ 1e817edPerformance Ratio: gradient time divided by log-density time. For very small models these ratios are noisy across runs and machines; raw primal and gradient timings are more reliable. The benchmarks are aimed at DynamicPPL developers and mainly catch obvious allocation or type-stability regressions. See benchmark notes for details. Main @ b8cd0cfEnvironmentJulia Version 1.13.0 Commit d1c37793dd2 (2026-09-09 19:00 UTC) Build Info: Official https://julialang.org release Platform Info: OS: Linux (x86_64-linux-gnu) CPU: 4 × AMD EPYC 7763 64-Core Processor WORD_SIZE: 64 LLVM: libLLVM-20.1.8 (ORCJIT, znver3) GC: Built with stock GC Threads: 1 default, 1 interactive, 1 GC (on 4 virtual cores) |
shravanngoswamii
force-pushed
the
sg/benchmark-report-to-file
branch
from
September 16, 2026 09:27
531ee91 to
1e817ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark comment carries a
Distributedworker's output, most visibly an Enzyme segfault backtrace in #1497.Each model runs in a worker so a crash cannot take down the suite. Julia relays a worker's stdout and stderr to the parent's stdout, and the workflow captures that whole stream as the report, so anything a worker prints is posted in the comment.
Redirecting for the duration of the run rather than changing how the report is captured, so
benchmarks.jlkeeps its current invocation and thebenchmark-mainjob, which runs main's copy of the script, is unaffected.Worker output and progress still reach the workflow log on stderr. The crash itself is untouched, and already shows in the table as
err.