Add SamplingOutput model evaluation and MCMCChains conversion - #1506
Conversation
Assisted-by: Codex <codex@openai.com>
Assisted-by: Codex <codex@openai.com>
Assisted-by: Codex <codex@openai.com>
Assisted-by: Codex <codex@openai.com>
Assisted-by: Codex <codex@openai.com>
Assisted-by: Codex <codex@openai.com>
Assisted-by: Codex <codex@openai.com>
Assisted-by: Codex <codex@openai.com>
Assisted-by: Codex <codex@openai.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1506 +/- ##
==========================================
+ Coverage 83.92% 84.09% +0.17%
==========================================
Files 54 54
Lines 4683 4741 +58
==========================================
+ Hits 3930 3987 +57
- Misses 753 754 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Assisted-by: Codex <codex@openai.com>
|
DynamicPPL.jl documentation for PR #1506 is available at: |
Benchmarks @ 7101ad6Performance Ratio: gradient time divided by log-density time. For very small models these ratios are noisy across runs and machines; raw primal and gradient timings are more reliable. The benchmarks are aimed at DynamicPPL developers and mainly catch obvious allocation or type-stability regressions. See benchmark notes for details. Main @ 7a7da38EnvironmentJulia Version 1.13.0 Commit d1c37793dd2 (2026-09-09 19:00 UTC) Build Info: Official https://julialang.org release Platform Info: OS: Linux (x86_64-linux-gnu) CPU: 4 × AMD EPYC 7763 64-Core Processor WORD_SIZE: 64 LLVM: libLLVM-20.1.8 (ORCJIT, znver3) GC: Built with stock GC Threads: 1 default, 1 interactive, 1 GC (on 4 virtual cores) |
shravanngoswamii
left a comment
There was a problem hiding this comment.
Should the Chains default for include_all flip to true to match this PR and FlexiChains, so the same call stops keeping supplied parameters for one chain type and dropping them for the other?
|
Thanks, @shravanngoswamii. Both should be fixed. I think |
Assisted-by: Codex <codex@openai.com>
This PR adds support for
SamplingOutput: modelreturned,predict, andpointwise log densities, plus conversion toMCMCChains.Chains. It also fixes a few minor issues inMCMCChains(see code).