Repository navigation
Polish exports: logo card on Band covers, readable PDF callouts, no stranded callouts (land #325 on main) - #328
Merged
Merged
Conversation
…tranded callouts - A logo that wouldn't show up on the Band cover's color (more than a quarter of its pixels under 3:1 against it, the WCAG minimum for graphics) sits on a white card in PDF, Word, HTML and the GIF title card, as it already did in PowerPoint. The check and the carded drawing are shared in exporters/branding.js, and PowerPoint now uses them too. - PDF callout labels use a darker shade of their color, at least 4.5:1 on the tint (amber on cream was about 2:1), like Word, HTML and Markdown. - PDF keeps short callouts placed after a screenshot on the screenshot's page, so one no longer starts the next page on its own. - The GIF title card counts every step, not just those with a screenshot, so the total matches the step numbers on the frames. - Word code blocks have padding; tables span the text (or column) width with a shaded header row. - HTML: callouts placed after a step title sit in the step body with the rest of the step, and the step number lines up with the first line of a long title.
A logo that was faint on the band always got a white card, so a white logo on a light band (#AAAAAA, say) vanished into its card. The card is now white or dark slate, whichever the logo stands out on, and is left off when neither would make the logo clearer than the band itself. The PowerPoint picture cover's card follows the same choice.
Polish exports: logo card on Band covers, readable PDF callouts, no stranded callouts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
No issue filed. #325 was stacked on #324's branch and was merged into that branch after #324 had already merged into
main, so its changes never reachedmain. This lands them.Summary
The export fixes from #325, unchanged. See #325 for the details:
Changes
819d321,62674d6), via its merge commit18ca034. No new code.Area
Testing
bash tests/run_test.shpassesMerging this branch into
maingives a tree identical to the one tested locally (mainwith #324 and #327, plus #325):npm test1644 pass, 0 fail, 26 skipped.Screenshots or recordings
See #325.
Rollout notes
None.
Checklist