Skip to content

Polish exports: logo card on Band covers, readable PDF callouts, no stranded callouts (land #325 on main) - #328

Merged
Twest2 merged 3 commits into
mainfrom
fix/land-export-polish
Nov 17, 2026
Merged

Twest2 merged 3 commits into
mainfrom
fix/land-export-polish

Conversation

@Twest2

@Twest2 Twest2 commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Issue

No issue filed. #325 was stacked on #324's branch and was merged into that branch after #324 had already merged into main, so its changes never reached main. This lands them.

Summary

The export fixes from #325, unchanged. See #325 for the details:

  • A logo that doesn't show up on the Brand color band cover sits on a card (white, or dark slate for a light logo) in PDF, Word, HTML and the GIF title card.
  • PDF callout labels are dark enough to read on their tint.
  • PDF keeps a short callout on the same page as the screenshot it follows.
  • The GIF title card counts every step.
  • Word code blocks are padded, and tables span the text width with a shaded header row.
  • HTML callouts after a step title sit in the step body, and step numbers line up with the first line of the title.

Changes

Area

  • Exports
  • Branding

Testing

  • bash tests/run_test.sh passes
  • Tested manually (describe below)

Merging this branch into main gives a tree identical to the one tested locally (main with #324 and #327, plus #325): npm test 1644 pass, 0 fail, 26 skipped.

Screenshots or recordings

See #325.

Rollout notes

None.

Checklist

  • Scope is limited to that issue
  • New behavior has tests that check real output
  • Anything that still needs manual verification is listed above
  • No new network calls, dependencies, or third-party branding

…tranded callouts

- A logo that wouldn't show up on the Band cover's color (more than a quarter
  of its pixels under 3:1 against it, the WCAG minimum for graphics) sits on
  a white card in PDF, Word, HTML and the GIF title card, as it already did in
  PowerPoint. The check and the carded drawing are shared in
  exporters/branding.js, and PowerPoint now uses them too.
- PDF callout labels use a darker shade of their color, at least 4.5:1 on the
  tint (amber on cream was about 2:1), like Word, HTML and Markdown.
- PDF keeps short callouts placed after a screenshot on the screenshot's page,
  so one no longer starts the next page on its own.
- The GIF title card counts every step, not just those with a screenshot, so
  the total matches the step numbers on the frames.
- Word code blocks have padding; tables span the text (or column) width with
  a shaded header row.
- HTML: callouts placed after a step title sit in the step body with the rest
  of the step, and the step number lines up with the first line of a long
  title.
A logo that was faint on the band always got a white card, so a white
logo on a light band (#AAAAAA, say) vanished into its card. The card is
now white or dark slate, whichever the logo stands out on, and is left
off when neither would make the logo clearer than the band itself. The
PowerPoint picture cover's card follows the same choice.
Polish exports: logo card on Band covers, readable PDF callouts, no stranded callouts
@Twest2
Twest2 merged commit 955de73 into main Nov 17, 2026
10 of 11 checks passed
@Twest2
Twest2 deleted the fix/land-export-polish branch November 17, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant