Repository navigation
fix(node)!: Gate agent-task reads behind visibility rules - #327
Closed
euxaristia wants to merge 31 commits into
Closed
euxaristia wants to merge 31 commits into
euxaristia wants to merge 31 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #395
Summary
Gates agent-task read surfaces behind repo and task visibility rules while preserving open-claim workflows, applying rate limiting across REST and GraphQL WebSockets, and enforcing hostile-node response limits in the CLI and MCP client.
Changes
/graphql/wswithTaskReadBraketo enforce the 5-field cap and per-IP rate limits over subscriptions.task_claimable) from read visibility (task_visible) so open unassigned tasks can be claimed without exposing task bodies on unauthenticated read queries.load_optional_keypair, terminating before issuing network calls on invalid paths.Prior reviewer feedback addressed
/graphql/wswithTaskReadBrakecontext and added production router integration tests.--dirto strict failure without network calls.LimitReached.Test plan
cargo test -p gitlawb-core -p glcargo clippy -p gl --all-targets -- -D warningscargo clippy --workspace -- -D warningscargo fmt --check