fix(api): harden presence + reported read paths and trust share formatting

[Ayush7614]

What / why

Three real, verified gaps — the leftovers after PR #83 hardened the meta/holder/count paths. Each is the outlier against its siblings:

1. Presence GET+POST HTML-500 on DB failure — app/src/app/api/presence/route.ts had zero error handling. readPulse/recordBeacon (presence.ts) throw on a configured-DB outage (maybeDb() null is safe, outage throws; memo.ts rethrows). Every sibling read route (feed/list/live/search/candles/holders/me/posts) wraps in try/catch → JSON 502 + no-store. The site-wide pulse (LivePulse.tsx, beacon every 30s) went silently stale on HTML 500s.
2. Reported-queue GET missing try/catch + a two-stage client break — app/src/app/api/posts/reported/route.ts threw instead of JSON-erroring, and AdminQueue.tsx called await res.json() before checking res.ok with no try/catch (invoked as void load()). So a DB blip became an unhandled promise rejection instead of the graceful error row a JSON error takes.
3. fmtShare painted NaN%/Infinity% — holders.ts: NaN <= 0 and NaN < 1 are both false, so NaN fell through to "NaN%"; Infinity → "Infinity%". Rendered in the trust-critical panel (HoldersPanel, TokenProof, trustNotes) where users judge rug risk. Every sibling guards (math.ts fmtCompact/fmtEth, market-format.ts marketUsd, chart-terminal.ts, and fix(api): harden launch read paths — meta error shape, bounded holder swaps, finite count formatting #83's marketCount).

Fix

• Presence GET + both POST branches: try/catch → JSON 502 + no-store + server log. Rate-limit bucket and prune logic untouched.
• Reported GET: keeps the current admin-session check (requireAdmin), then try/catch → JSON 502 + private, no-store. AdminQueue.load(): defensive JSON parse (non-JSON → moderation queue returned <status>), friendlyError surfacing, setPosts(null) on failure — no more unhandled rejections.
• fmtShare: !Number.isFinite → "—", matching siblings.

Uniqueness check (no open/merged/closed duplicate)

• Open: fix(api): harden launch read paths — meta error shape, bounded holder swaps, finite count formatting #83 (meta GETs / holder-scan bound / marketCount — different files), Quote only fees #82 quote-only-fees, profiles: usernames everywhere, a ✓ from one X post, smart-wallet trades credited to the right wallet #81 profiles, fix(charts): harden optional Gecko chart recovery #43 gecko-charts, feat(app): add watchlists and a cleaner full-width UI #34 watchlist, perf(posts): memoised replies, paginated comments, persistent drafts #31 token-comments-UX.
• Merged: Fix/feed dust floor #48 feed-dust, fix(ui): reject scientific-notation amounts, guard tiny-negative USD and share-card numbers #47 amount-format-guards (math/market-format only — fmtShare untouched), fix(api): clamp posts feed pagination, JSON errors on hot GETs, 404 on missing moderated post #46 posts-feed-hardening (feed/token-posts paging, not the admin reported route), fix(ui): reject ambiguous decimal separators instead of rewriting them #56 decimal-input, fix(search): order cross-chain results by block time and escape LIKE wildcards #35 search, fix(memo): bound the cache with per-entry TTL expiry and oldest-first eviction #36 memo-cap, feat(security): per-IP rate limits on sync/meta/presence POST endpoints #37 write-limits (write buckets; presence beacon bucket already existed and is untouched), fix(app): improve launch input, fees and notifications #40 input-notifications.
• Issues: Consider AGPLv3 for future OpenLaunch releases #59 AGPL, Edit metadata: wallet rate-limit DoS and nonce burned before signature verify #9 closed edit-metadata. None touch presence, reported, or fmtShare.

Verification (all true, nothing faked)

• Repro: node -e confirms old fmtShare(NaN) → "NaN%", Infinity → "Infinity%"; new → "—" (test added).
• New/extend tests: holders.test.ts non-finite fmtShare cases, new presence.test.ts (bot allow-list, 64-hex visitor-hash uniqueness/stability).
• npm test: 1371 pass / 0 fail / 11 skipped.
• npm run typecheck: clean. eslint on all touched files: clean. npm run build: pass.
• Rebased onto upstream/main@1e006c3; the conflict in the reported route / AdminQueue was resolved keeping the new requireAdmin + useAdminAccount auth. Head 2c54f91, CI green.

[coderabbitai]

Warning

Review limit reached

Only developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing.

Next included review available in 43 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 81a5521e-dfe1-4583-b2e6-16a8cf9a8e7b

📥 Commits

Reviewing files that changed from the base of the PR and between 1e006c3 and 2c54f91.

📒 Files selected for processing: 6

• app/src/app/api/posts/reported/route.ts
• app/src/app/api/presence/route.ts
• app/src/components/launchpad/AdminQueue.tsx
• app/src/lib/launchpad/holders.test.ts
• app/src/lib/launchpad/holders.ts
• app/src/lib/launchpad/presence.test.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[Vasanthdev2004]

These fixes still address gaps on main. Please sync the branch first: the reported-post route and AdminQueue now use authenticated admin sessions. Keep requireAdmin, useAdminAccount, the private/no-store response policy and the endpoint without ?wallet= while adding the error handling.

Please also add focused tests for the database failure and non-JSON/network-error paths, then rerun CI on the updated head. The current helper tests don't exercise those failures, and the older green checks don't cover the new auth integration.

[Ayush7614]

Thanks for the feedback @Vasanthdev2004

Rebased onto current upstream/main (1e006c3), which had moved the moderation queue to admin sessions (requireAdmin + useAdminAccount). The rebase conflict is resolved by keeping that auth and layering the error handling on top:

• GET /api/posts/reported keeps requireAdmin, wraps listReported() in try/catch → JSON 502 + private, no-store.
• AdminQueue.load() no longer sends the removed ?wallet= param; it parses JSON defensively, shows friendlyError, and clears the list instead of throwing an unhandled rejection.
• Presence and fmtShare changes applied unchanged.

New head 2c54f91; CI green (app lint/typecheck/tests/build, contracts, guard, deps). Local verification: 1371 pass / 0 fail / 11 skipped, typecheck + eslint clean, production build passes.