chore(submodule): bump backend to 8ccc3b5 and frontend to bad7c51 (NEH-222) - #323
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The frontend commit violates CSS placement rules and omits required 800×480 and 1024×600 layout tests.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates backend and frontend submodules for NEH-222 live-preview framing.
Changes:
- Aligns backend preview framing with still-capture configuration.
- Sizes frontend viewports from camera-frame aspect ratios.
File summaries
| File | Description |
|---|---|
backend |
Pins backend commit 8ccc3b5. |
frontend |
Pins frontend commit bad7c51. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins backend at 8ccc3b5 (merge of backend #91) and frontend at bad7c51 (merge of frontend #92), both NEH-222: the live preview reads from the still's own configuration, and the viewport takes its shape from the frames. Backend gate 278 passed in Docker and CI green; frontend 191 tests, svelte-check 0 errors. Hardware acceptance is bench row B14.