Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
…upstream-native-ball-intro-phase
…upstream-native-ball-intro-phase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
World presentation could request cartridge door metadata while building the third-person view, but the query was missing. Import genuine descriptor tables for authenticated FireRed, LeafGreen, Emerald, Ruby and Sapphire cartridges, and resolve door queries through the admitted native map/cell. Return detached descriptor/geometry metadata and a per-cohort manifest; reject non-door cells, padded/out-of-bounds coordinates, foreign identities and missing/retired imports. The GBA generated-cache marker changes; save formats do not.
Validation: 66 binary-reader assertions, 95 native query assertions, 75 existing slide-observation assertions and map/weather/cache regressions pass. All 185 real descriptors from five authenticated cartridges read correctly (32/32/53/34/34). The composed current-main build passes 250 frozen CPU groups. The independent older public composition passes 78 groups with its original native controllers and existing map/session prerequisites retained. The unchanged-consumer native FireRed run freshly imports the new descriptors and passes clear/rain × Normal/Third/First: twelve on/off images, restored real scene targets, 9,368 observed native actor mirror draws and exact collision/elevation/metatile/warp snapshots. All six enabled images and Third on/off pairs were inspected. QA accelerates puddle fill only for this matrix; production timing is unchanged. This is bounded scene functionality, not all-edition or FPS acceptance.
This provides descriptors and read-side queries. General door animation/task/sound coordination and sustained field FPS remain separate work. The public composition requires the existing native map/session/collision foundations; those controllers are not replaced here. No ROM assets, private renderer source or player saves are included. QA enforced 20 GiB free, above the requested 8 GiB reserve.
Contributions by Roxas2712 — https://github.com/Roxas2712. Original additions are offered under LICENSE-ROXAS2712.md, including specific integration/distribution permission for Cedric / UNDERdecoded with visible credit. Existing upstream/third-party licences and rights remain intact.