Conversation
* starting lake watershed function in lake_watersheds branch * get rid of misnamed test nlcd files * tinkering with lake watersheds * added lc_get_watershed function to get watershed polygons from S3 * added lc_get_watershed function with optimizations * added vignette section for lc_get_watershed * added vignette for lc_get_watershed * updated lc_get_watershed function and added a section in the LakeCat article to describe * added tictoc to suggests in Description * trying to get rid of geoarrow dependency issue * got rid of accidental draft code still in lc_get_data * fixed deprecated functions and NAMESPACE * fixed depreacted functions and NAMESPACE * updating get_params functions * added test coverage for new lc_get_watershed function
* tune-ups to functions using suggestions from @pauldzy an fixing a few odds and ends * revolving pct_full error with all metrics and converting nhdplusTools to hydrogeofetch * nhdplusTools to hydrogeofetch conversion * ci: use CRAN for package resolution, install system deps, add pak debug step * install pak, use exported pak APIs, and bump cache-version * rollback move to hydrogeofetch; will wait until CRAN release * missed a couple spots where hydrogeofetch:: was still being called
* migrate nhdplusTools to hydrogeofetch * one more switch from nhdplusTools
Merge branch 'master' of https://github.com/USEPA/StreamCatTools into develop # Conflicts: # .github/workflows/coverage.yaml # DESCRIPTION # NEWS.md # R/lc_get_data.R # R/sc_get_data.R # R/sc_plot.R # cran-comments.md # docs/404.html # docs/LICENSE.html # docs/articles/Articles/Applications.html # docs/articles/Articles/Applications_files/leaflet-providers-3.0.0/leaflet-providers.js # docs/articles/Articles/Introduction.html # docs/articles/Articles/LakeCat.html # docs/articles/Articles/LakeCat_files/HomeButton-0.0.1/LICENSE # docs/articles/Articles/LakeCat_files/HomeButton-0.0.1/easy-button-src.min.js # docs/articles/Articles/LakeCat_files/HomeButton-0.0.1/glyphicons-21-home.png # docs/articles/Articles/LakeCat_files/HomeButton-0.0.1/home-button.js # docs/articles/Articles/LakeCat_files/Lake-CSS-0.0.1/Lake_home-button.css # docs/articles/Articles/LakeCat_files/Proj4Leaflet-1.0.1/proj4leaflet.js # docs/articles/Articles/LakeCat_files/Watershed-CSS-0.0.1/Watershed_home-button.css # docs/articles/Articles/LakeCat_files/clipboard-0.0.1/setClipboardText.js # docs/articles/Articles/LakeCat_files/htmltools-fill-0.5.9/fill.css # docs/articles/Articles/LakeCat_files/htmlwidgets-1.6.4/htmlwidgets.js # docs/articles/Articles/LakeCat_files/leaflet-1.3.1/images/layers-2x.png # docs/articles/Articles/LakeCat_files/leaflet-1.3.1/images/layers.png # docs/articles/Articles/LakeCat_files/leaflet-1.3.1/images/marker-icon-2x.png # docs/articles/Articles/LakeCat_files/leaflet-1.3.1/images/marker-icon.png # docs/articles/Articles/LakeCat_files/leaflet-1.3.1/images/marker-shadow.png # docs/articles/Articles/LakeCat_files/leaflet-1.3.1/leaflet.css # docs/articles/Articles/LakeCat_files/leaflet-1.3.1/leaflet.js # docs/articles/Articles/LakeCat_files/leaflet-binding-2.2.3/leaflet.js # docs/articles/Articles/LakeCat_files/leaflet-providers-3.0.0/leaflet-providers.js # docs/articles/Articles/LakeCat_files/leaflet-providers-plugin-2.2.3/leaflet-providers-plugin.js # docs/articles/Articles/LakeCat_files/leafletfix-1.0.0/leafletfix.css # docs/articles/Articles/LakeCat_files/mapviewCSS-0.0.1/mapview-popup.css # docs/articles/Articles/LakeCat_files/mapviewCSS-0.0.1/mapview.css # docs/articles/Articles/LakeCat_files/proj4-2.6.2/proj4.min.js # docs/articles/Articles/LakeCat_files/rstudio_leaflet-1.3.1/images/1px.png # docs/articles/Articles/LakeCat_files/rstudio_leaflet-1.3.1/rstudio_leaflet.css # docs/articles/Articles/NNI.html # docs/articles/Articles/NNI_files/figure-html/map1-1.png # docs/articles/Articles/NNI_files/figure-html/map2-1.png # docs/articles/Articles/NNI_files/figure-html/map3-1.png # docs/articles/Articles/NNI_files/figure-html/unnamed-chunk-2-1.png # docs/articles/Articles/NNI_files/figure-html/unnamed-chunk-3-1.png # docs/articles/Articles/NNI_files/figure-html/unnamed-chunk-7-1.png # docs/articles/StartHere.html # docs/articles/index.html # docs/authors.html # docs/deps/data-deps.txt # docs/index.html # docs/news/index.html # docs/pkgdown.yml # docs/reference/index.html # docs/reference/lc_fullname.html # docs/reference/lc_get_comid.html # docs/reference/lc_get_data.html # docs/reference/lc_get_metric_names.html # docs/reference/lc_get_nlcd.html # docs/reference/lc_get_nni.html # docs/reference/lc_get_params.html # docs/reference/lc_plotnni.html # docs/reference/sc_fullname.html # docs/reference/sc_get_comid.html # docs/reference/sc_get_data.html # docs/reference/sc_get_metric_names.html # docs/reference/sc_get_nlcd.html # docs/reference/sc_get_nni.html # docs/reference/sc_get_params.html # docs/reference/sc_plotnni.html # docs/search.json # docs/sitemap.xml # vignettes/Articles/LakeCat.Rmd
This reverts commit 0327900.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging in CRAN release on develop of StreamCatTools 0.12.0 that:
sc_get_comidwith a new REST service implementation usingthe EPA NHDPlus NP21 simplified catchments layer.
count_metricshelper functionsc_get_dataandlc_get_dataslightly for improvedfunctionality (based on https://github.com/pauldzy/StreamCatTools)