Skip to content

Space Weather Bugs - #10

Draft
aburrell wants to merge 23 commits into
developfrom
solargeomag_bugs
Draft

aburrell wants to merge 23 commits into
developfrom
solargeomag_bugs

Conversation

@aburrell

@aburrell aburrell commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Fixes to bugs found when using the space weather instruments and methods.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Ran various concatenation routines.

Test Configuration:

  • Operating system: OS X Tahoe
  • Version number: Python 3.10
  • Any details about your local setup that are relevant

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have linted the files updated in this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update CITATION.cff file for new code contributors

If this is a release PR, replace the first item of the above checklist with the
release checklist on this wiki:
https://github.com/aburrell/ocbpy/wiki/Release-Checklist

Added a flag to turn off verify, making downloads more secure by default and still allowing a bypass.
Added a verify flag to the GFZ downloads.
Check that the meta data exists before accessing it.
Fixed bugs where meta data was not transferred when combining data, updated the default index name for F10.7 data, and removed attempted access to the pysat Meta class.
Add a summary of changes to the changelog.
@coveralls

coveralls commented Oct 19, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 40726595421

Coverage decreased (-0.05%) to 94.5%

Details

  • Coverage decreased (-0.05%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 52 coverage regressions across 12 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

52 previously-covered lines in 12 files lost coverage.

Top 10 Files by Coverage Loss Lines Losing Coverage Coverage
instruments/sw_methods/f107.py 13 92.47%
tests/test_instrument.py 10 95.2%
_files.py 7 91.1%
instruments/sw_methods/gfz.py 6 95.95%
instruments/sw_methods/kp_ap.py 5 98.11%
instruments/sw_methods/swpc.py 2 87.83%
instruments/sw_ssn.py 2 77.89%
_params.py 2 96.3%
utils/_core.py 2 98.25%
instruments/sw_f107.py 1 81.51%

Coverage Stats

Coverage Status
Relevant Lines: 11218
Covered Lines: 10601
Line Coverage: 94.5%
Coverage Strength: 15.49 hits per line

💛 - Coveralls

Fixed wording of 'verify' description.
Added tests for the F10.7 index name and presence of attributes after using the combine function.
Added a test for the convert Kp routine in the absence of a fill value attribute.
@aburrell

Copy link
Copy Markdown
Collaborator Author

Current failures have to do with the GFZ DOI'd data site having the downloads not working. I contacted them in case they were unaware of the issue and to ask for a status update.

@aburrell aburrell added this to the v0.1.0 milestone Oct 23, 2026
@aburrell aburrell linked an issue Oct 23, 2026 that may be closed by this pull request
Added a check and logger warning for instances where the downloaded files do not match the requested range of files.
Fixed the evaluation of files when attempting to refresh an empty instrument; allows the code to gracefully inform the user of the lack of files.
Added a test for the new download logger warning.
Added the enhancement to the changelog.
@aburrell

Copy link
Copy Markdown
Collaborator Author

The GFZ failures are due to the recent PHP problem: https://www.cyber.gc.ca/en/news-events/statement-regarding-critical-vulnerabilities-php-affecting-websites-online-services.

Once this is resolved, update the docs to fix the permanently redirected links as an additional improvement to trigger the unit tests.

The SWPC webpage has moved, update the links.
Updated a redirecting link.
Updated the redirecting link.
Added the documentation update to the changelog.
An attempted fix for the windows implementation.
Numpy timedelta64 now requires a unit specification.
Update a redirecting link.
The Windows FileNotFoundError class doesn't have a message attribute.
@aburrell aburrell linked an issue Oct 28, 2026 that may be closed by this pull request
If any entry in `os.path.join` is a single directory separator, the entire path is set to be just that.  Update the subdirectory path to be empty instead of a directory separator if there is no subdirectory structure.
When removing a prefix that may not be in all variable names, do not rename variables whose names are unchanged.
Add additional changes to the changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: numpy deprecation warning BUG: sw_f107 historic data not available after 2018-04-30

2 participants