Repository navigation
Conversation
Added a flag to turn off verify, making downloads more secure by default and still allowing a bypass.
Added a verify flag to the GFZ downloads.
Check that the meta data exists before accessing it.
Fixed bugs where meta data was not transferred when combining data, updated the default index name for F10.7 data, and removed attempted access to the pysat Meta class.
Add a summary of changes to the changelog.
Coverage Report for CI Build 40726595421Coverage decreased (-0.05%) to 94.5%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions52 previously-covered lines in 12 files lost coverage.
Coverage Stats
💛 - Coveralls |
Fixed wording of 'verify' description.
Added tests for the F10.7 index name and presence of attributes after using the combine function.
Added a test for the convert Kp routine in the absence of a fill value attribute.
Collaborator
Author
|
Current failures have to do with the GFZ DOI'd data site having the downloads not working. I contacted them in case they were unaware of the issue and to ask for a status update. |
Added a check and logger warning for instances where the downloaded files do not match the requested range of files.
Fixed the evaluation of files when attempting to refresh an empty instrument; allows the code to gracefully inform the user of the lack of files.
Added a test for the new download logger warning.
Added the enhancement to the changelog.
Collaborator
Author
|
The GFZ failures are due to the recent PHP problem: https://www.cyber.gc.ca/en/news-events/statement-regarding-critical-vulnerabilities-php-affecting-websites-online-services. Once this is resolved, update the docs to fix the permanently redirected links as an additional improvement to trigger the unit tests. |
The SWPC webpage has moved, update the links.
Updated a redirecting link.
Updated the redirecting link.
Added the documentation update to the changelog.
An attempted fix for the windows implementation.
Numpy timedelta64 now requires a unit specification.
Update a redirecting link.
The Windows FileNotFoundError class doesn't have a message attribute.
If any entry in `os.path.join` is a single directory separator, the entire path is set to be just that. Update the subdirectory path to be empty instead of a directory separator if there is no subdirectory structure.
When removing a prefix that may not be in all variable names, do not rename variables whose names are unchanged.
Add additional changes to the changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes to bugs found when using the space weather instruments and methods.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran various concatenation routines.
Test Configuration:
Checklist:
develop(notmain) branchCHANGELOG.md, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on this wiki:
https://github.com/aburrell/ocbpy/wiki/Release-Checklist