chore(ci): bump review-cli to 1.10.6 - #703
claude[bot] wants to merge 1 commit into
Conversation
Bump the pinned @uniswap/review-cli fallback from 1.6.0 to 1.10.6 at all three install_review_cli call sites: - .github/workflows/claude-code-review.yml (triage + review jobs) - .github/workflows/review-feedback.yml (emit job) These literals are only the fallback behind the REVIEW_CLI_VERSION repo variable, which remains the authoritative pin. The variable must be bumped separately in repo settings for this to take effect. Claude-Session: https://claude.ai/code/session_012AthXFyFpBgTWFebPdezNU
|
● Reviewed · against Note Approved. Bumps the pinned Tip Teach the reviewer. React 👍 on findings that helped, 👎 on false positives. Reply to push back or add context — we aggregate this weekly to tune the bot. Comment |
There was a problem hiding this comment.
Note
✅ Approved — see full review in the sticky comment ↑
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (08/21/26)3 reviewers were added to this PR based on Siyu Jiang (See-You John)'s automation. |
Requested by Erin Hales · Slack thread
PR Scope
chore(ci):— internal CI-only change, triggers no SDK release. No package code touched.Description
Bumps the pinned
@uniswap/review-clifallback from 1.6.0 to 1.10.6 at all threeinstall_review_clicall sites:.github/workflows/claude-code-review.ymltriage.github/workflows/claude-code-review.ymlreview.github/workflows/review-feedback.ymlemitEach is the same one-line change:
Two things worth flagging for the reviewer:
1. This is a 1.6.0 → 1.10.6 jump. This repo was further behind than most — the sibling repos were sitting on 1.10.x already — so there are considerably more release notes between these two versions than in a typical bump. Worth a skim of the intervening changelog rather than assuming it is a patch-level no-op.
2. The literal changed here is only the fallback. The authoritative pin is the
vars.REVIEW_CLI_VERSIONrepo variable, and${{ vars.X || '<literal>' }}means the literal is consulted only when that variable is unset or deleted. A pull request cannot set a repo variable — so merging this alone will not change which version CI installs. Someone with repo-settings access needs to bumpREVIEW_CLI_VERSIONseparately (Settings → Secrets and variables → Actions → Variables) for the upgrade to actually take effect. This PR makes the floor correct for the case where that variable is ever cleared, and keeps the checked-in default from drifting further behind.No dependency manifest or lockfile changes:
@uniswap/review-cliis installed at runtime by the composite action into an isolated$RUNNER_TEMPdir, and appears nowhere in anypackage.jsonor inbun.lock. Verified by grep before and after.I left the justification comment above the first call site (lines 150-159) in place. Unlike the equivalent comment in the
Uniswap/universechange, it does not pin its rationale to the old version — it documents that the repo variable is authoritative, a>= 1.4.3floor (a transitive@modelcontextprotocol/serverresolution bug), and a "never@latest" rule. All three still hold at 1.10.6, and the>= 1.4.3floor remains a live guardrail against a future downgrade, so removing it would lose information.How Has This Been Tested?
CI-config change, so validation is static — the install step only executes on a real workflow run:
.github/workflows/plus.github/actions/install_review_cli/action.ymlload cleanly.usescontainsinstall_review_cliand printed the resolvedversioninput. All three report${{ vars.REVIEW_CLI_VERSION || '1.10.6' }}; no call site was missed.version:keys in either workflow file, so there was no adjacent version input that could have been hit by mistake. Thebun-versioninput in the composite action is a different key in a different file and is untouched.grep -rn '1\.6\.0' .github/returns nothing.actionlintwas not run: this repo has noactionlintconfig, nolint:actionsscript, and noactionlintbinary available in the environment. Flagging rather than silently skipping.Are there any breaking changes?
No. No exported types, function signatures, or published SDK code are touched — the change is confined to two GitHub Actions workflow files.
(Optional) Feedback Focus
Whether 1.10.6 is the version this repo actually wants, given the size of the jump. If any of the intervening releases changed
.claude/review.ymlschema expectations, this repo's config usesmodel.default(notmodel.synthesis), which is worth a sanity check against the 1.10.x config schema.(Optional) Follow Ups
REVIEW_CLI_VERSIONrepo variable to1.10.6— required for this bump to have any runtime effect.bunx @uniswap/review-cli upgrade), which would remove the need to hand-maintain these fallbacks. Not attempted here.Generated by Claude Code