Skip to content

chore(ci): bump review-cli to 1.10.6 - #703

Open
claude[bot] wants to merge 1 commit into
mainfrom
claude/bump-review-cli-1.10.6
Open

claude[bot] wants to merge 1 commit into
mainfrom
claude/bump-review-cli-1.10.6

Conversation

@claude

@claude claude Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Requested by Erin Hales · Slack thread

PR Scope

chore(ci): — internal CI-only change, triggers no SDK release. No package code touched.

Description

Bumps the pinned @uniswap/review-cli fallback from 1.6.0 to 1.10.6 at all three install_review_cli call sites:

File Job Line
.github/workflows/claude-code-review.yml triage 160
.github/workflows/claude-code-review.yml review 290
.github/workflows/review-feedback.yml emit 66

Each is the same one-line change:

-          version: ${{ vars.REVIEW_CLI_VERSION || '1.6.0' }}
+          version: ${{ vars.REVIEW_CLI_VERSION || '1.10.6' }}

Two things worth flagging for the reviewer:

1. This is a 1.6.0 → 1.10.6 jump. This repo was further behind than most — the sibling repos were sitting on 1.10.x already — so there are considerably more release notes between these two versions than in a typical bump. Worth a skim of the intervening changelog rather than assuming it is a patch-level no-op.

2. The literal changed here is only the fallback. The authoritative pin is the vars.REVIEW_CLI_VERSION repo variable, and ${{ vars.X || '<literal>' }} means the literal is consulted only when that variable is unset or deleted. A pull request cannot set a repo variable — so merging this alone will not change which version CI installs. Someone with repo-settings access needs to bump REVIEW_CLI_VERSION separately (Settings → Secrets and variables → Actions → Variables) for the upgrade to actually take effect. This PR makes the floor correct for the case where that variable is ever cleared, and keeps the checked-in default from drifting further behind.

No dependency manifest or lockfile changes: @uniswap/review-cli is installed at runtime by the composite action into an isolated $RUNNER_TEMP dir, and appears nowhere in any package.json or in bun.lock. Verified by grep before and after.

I left the justification comment above the first call site (lines 150-159) in place. Unlike the equivalent comment in the Uniswap/universe change, it does not pin its rationale to the old version — it documents that the repo variable is authoritative, a >= 1.4.3 floor (a transitive @modelcontextprotocol/server resolution bug), and a "never @latest" rule. All three still hold at 1.10.6, and the >= 1.4.3 floor remains a live guardrail against a future downgrade, so removing it would lose information.

How Has This Been Tested?

CI-config change, so validation is static — the install step only executes on a real workflow run:

  • YAML parses — all 11 files under .github/workflows/ plus .github/actions/install_review_cli/action.yml load cleanly.
  • Semantic check — walked the parsed YAML for every step whose uses contains install_review_cli and printed the resolved version input. All three report ${{ vars.REVIEW_CLI_VERSION || '1.10.6' }}; no call site was missed.
  • Wrong-key risk ruled out — these three were the only version: keys in either workflow file, so there was no adjacent version input that could have been hit by mistake. The bun-version input in the composite action is a different key in a different file and is untouched.
  • No stale pingrep -rn '1\.6\.0' .github/ returns nothing.
  • Diff is exactly 3 lines across 2 files, all three identical in shape.

actionlint was not run: this repo has no actionlint config, no lint:actions script, and no actionlint binary available in the environment. Flagging rather than silently skipping.

Are there any breaking changes?

No. No exported types, function signatures, or published SDK code are touched — the change is confined to two GitHub Actions workflow files.

(Optional) Feedback Focus

Whether 1.10.6 is the version this repo actually wants, given the size of the jump. If any of the intervening releases changed .claude/review.yml schema expectations, this repo's config uses model.default (not model.synthesis), which is worth a sanity check against the 1.10.x config schema.

(Optional) Follow Ups

  • Bump the REVIEW_CLI_VERSION repo variable to 1.10.6required for this bump to have any runtime effect.
  • The composite action's header notes a possible future migration to the canonical action shipped by review-cli itself (bunx @uniswap/review-cli upgrade), which would remove the need to hand-maintain these fallbacks. Not attempted here.

Generated by Claude Code

Bump the pinned @uniswap/review-cli fallback from 1.6.0 to 1.10.6 at
all three install_review_cli call sites:

- .github/workflows/claude-code-review.yml (triage + review jobs)
- .github/workflows/review-feedback.yml (emit job)

These literals are only the fallback behind the REVIEW_CLI_VERSION
repo variable, which remains the authoritative pin. The variable must
be bumped separately in repo settings for this to take effect.

Claude-Session: https://claude.ai/code/session_012AthXFyFpBgTWFebPdezNU
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

● Reviewed · against 598f98d · 2026-08-21 16:54 UTC · view run ↗

Note

Approved.

Bumps the pinned @uniswap/review-cli fallback from 1.6.0 to 1.10.6 at all three install_review_cli call sites. The literal is only the fallback in ${{ vars.REVIEW_CLI_VERSION || '1.10.6' }} — merging this alone doesn't change which version CI installs until someone bumps the REVIEW_CLI_VERSION repo variable.

Tip

Teach the reviewer. React 👍 on findings that helped, 👎 on false positives. Reply to push back or add context — we aggregate this weekly to tune the bot.

Comment @request-claude-review to re-run.

@graphite-app
graphite-app Bot requested review from a team August 21, 2026 16:53

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Approved — see full review in the sticky comment ↑

@graphite-app

graphite-app Bot commented Aug 21, 2026

Copy link
Copy Markdown

Graphite Automations

"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (08/21/26)

3 reviewers were added to this PR based on Siyu Jiang (See-You John)'s automation.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant