Skip to content

switched from hardcoded refs to the split system, netstandard and mscorlib; guaranteeing compatibility with .NET 10 - #227

Merged
todi1856 merged 2 commits into
masterfrom
core/uum-156036
Oct 15, 2026
Merged

todi1856 merged 2 commits into
masterfrom
core/uum-156036

Conversation

@seprab

@seprab seprab commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Yamato CI

Purpose of PR

Type of change:

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)
  • Description of the feature
    Test-only fix for .NET 10 / CoreCLR. AndroidLogcatNetTests.ValidateAssemblyReferences hard-coded the .NET Framework/netstandard reference names (mscorlib, System, System.Core, System.Xml.Linq). When the package is compiled for net10, the assembly references the split System.* facades instead (System.Runtime, System.Collections, System.Linq, …), so the test failed with 13 "Unexpected reference" and 4 "expected to be referenced once" errors, even though the package code did not change.
    The test now skips built-in .NET system libraries (mscorlib, netstandard, System, System.*) and still checks every other reference, so it keeps catching accidental references to Unity, test, or third-party assemblies on both netstandard and net10.

  • Links to screenshots, design docs, user docs, etc.
    N/A

  • Links to Jira/Fogbugz cases
    UUM-156036 (part of epic VM-3393, CoreCLRNet10PackageCompatibility)

  • Halo effect
    Tests only.

  • Performance Impact
    None. Tests only.

  • Package requirements
    The fix works on netstandard (6000.x) and net10 (7000.x+) compiles.

Checklist for PR maker

  • Have you added a backport label? (if needed)
  • Have you updated the Changelog? Each package has a CHANGELOG.md file
  • Have you added or updated the Documentation to your PR? When you add a new feature, change a property name, or change the behaviour of a feature, it's best practice to include related documentation changes in the same PR

Testing status

Updated the existing AndroidLogcatNetTests.ValidateAssemblyReferences. No new tests. And I also ensured that all the other tests continued to succeed.

  • What environment did you test on?
    I ran Editor tests in Windows and the Player tests on Windows/Android Player.

Any existing projects ready for testing should be noted here

  • Testing checklist
  • Built and run editor Locally or Katana
  • Built a player Android/iOS (if applicable)
  • Run on device Android/iOS (if applicable)
  • If new feature has UI, does it match Unity style? (Unity HIG?)
  • Tested Undo/Redo + Prefab overrides + Alignment in Preset
  • All items have tooltips?

Note to guardian

None.

Comments to reviewers

None.

…orlib; guaranteeing compatibility with .NET 10 and backwards

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Ship it

The change accommodates varying .NET framework references while preserving checks for other dependencies. I examined the filtering, expected-reference counts, and supported Unity version and found no actionable issues.

Reviewed commit 51dd40d

🤖 Helpful? 👍/👎

@seprab seprab self-assigned this Oct 15, 2026
@seprab
seprab requested a review from todi1856 October 15, 2026 14:23
@todi1856
todi1856 enabled auto-merge October 15, 2026 14:45
@todi1856

Copy link
Copy Markdown
Member

Enabled auto merge, so no need to for manual merge click

@todi1856
todi1856 merged commit 4f935d0 into master Oct 15, 2026
23 checks passed
@todi1856
todi1856 deleted the core/uum-156036 branch October 20, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants