Repository navigation
switched from hardcoded refs to the split system, netstandard and mscorlib; guaranteeing compatibility with .NET 10 - #227
Merged
Merged
Conversation
…orlib; guaranteeing compatibility with .NET 10 and backwards
Contributor
There was a problem hiding this comment.
💡 Harness Review
The change accommodates varying .NET framework references while preserving checks for other dependencies. I examined the filtering, expected-reference counts, and supported Unity version and found no actionable issues.
Reviewed commit 51dd40d
🤖 Helpful? 👍/👎
todi1856
approved these changes
Oct 15, 2026
todi1856
enabled auto-merge
October 15, 2026 14:45
Member
|
Enabled auto merge, so no need to for manual merge click |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR
Type of change:
Description of the feature
Test-only fix for .NET 10 / CoreCLR.
AndroidLogcatNetTests.ValidateAssemblyReferenceshard-coded the .NET Framework/netstandard reference names (mscorlib,System,System.Core,System.Xml.Linq). When the package is compiled for net10, the assembly references the splitSystem.*facades instead (System.Runtime,System.Collections,System.Linq, …), so the test failed with 13 "Unexpected reference" and 4 "expected to be referenced once" errors, even though the package code did not change.The test now skips built-in .NET system libraries (
mscorlib,netstandard,System,System.*) and still checks every other reference, so it keeps catching accidental references to Unity, test, or third-party assemblies on both netstandard and net10.Links to screenshots, design docs, user docs, etc.
N/A
Links to Jira/Fogbugz cases
UUM-156036 (part of epic VM-3393, CoreCLRNet10PackageCompatibility)
Halo effect
Tests only.
Performance Impact
None. Tests only.
Package requirements
The fix works on netstandard (6000.x) and net10 (7000.x+) compiles.
Checklist for PR maker
CHANGELOG.mdfileTesting status
Updated the existing
AndroidLogcatNetTests.ValidateAssemblyReferences. No new tests. And I also ensured that all the other tests continued to succeed.I ran Editor tests in Windows and the Player tests on Windows/Android Player.
Any existing projects ready for testing should be noted here
Note to guardian
None.
Comments to reviewers
None.