Repository navigation
Replace CustomSampler with ProfilerMarker in AndroidLogcatDispatcher - #232
Merged
Merged
Conversation
Cherry-picked from #230 (AndroidLogcatDispatcher.cs only). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
todi1856
enabled auto-merge
October 30, 2026 08:49
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Harness Review
The change replaces the per-instance CustomSampler with a static ProfilerMarker while retaining the existing sampling boundaries. I examined dispatcher initialization, worker execution, exception handling, existing tests, and Unity compatibility requirements; no actionable issues were found.
Reviewed commit 9a7f8b3
🤖 Helpful? 👍/👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking changes #230 minus test changes, since those are incorrect