Repository navigation
Paint underlines below the baseline and strikethroughs above it - #8
Merged
kaylafortin merged 1 commit intoOct 6, 2026
Merged
Conversation
Parley's run metrics carry the font's decoration offsets as the font stores them, y-up: a post-table underline position below the baseline is negative, an OS/2 strikeout position above it is positive. gpui adds the fragment offsets to baseline_y in y-down space, so every underline was painted through the letters and every strikethrough under them. Flip both offsets where the Parley text system builds paint fragments.
marieletellier
approved these changes
Oct 6, 2026
kaylafortin
merged commit Oct 6, 2026
f0347a3
into
unity/wayland-early-app-id
11 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: HUB-8063
Since the move to Parley, the native Hub paints every underline through the letters and every strikethrough below them. Parley's run metrics are y-up (font convention), gpui adds them to
baseline_yin y-down space. This flips both offsets inParleyTextSystemand adds a regression test.Based on
unity/wayland-early-app-id(the Hub's current pin,2f324088), so the diff is this one commit. The same commit, cherry-picked onto upstreammain, is proposed upstream: gpui-ce#324Tests:
cargo test -p gpui_ce_parley(61 pass, the new test fails without the fix),cargo test -p gpui-ce --lib text_system(14 pass), clippy and fmt clean. Checked in the native Hub on macOS arm64 (Learn tab "Read more").🤖 Generated with Claude Code