BehaviorParametersEditor: create new sensors only when needed. - #6323
Merged
Merged
Conversation
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Harness Review
The play-mode cache reuse avoids the repeated sensor recreation, but it can retain a sensor list across an agent disable/enable lifecycle that no longer represents the components to be initialized.
Reviewed commit 97146cc
🤖 Helpful? 👍/👎
Contributor
Author
|
/review |
There was a problem hiding this comment.
💡 Harness Review
The play-mode reuse path correctly avoids replacing an active agent’s live sensors, but the new uninitialized-agent branch can repeatedly create resource-owning sensors without releasing the prior temporary instances.
Reviewed commit 2b32fd1
🤖 Helpful? 👍/👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Make BehaviorParametersEditor create new sensors only when needed.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Fixes #6318
Types of change(s)
Checklist