Repository navigation
ci: migrate releases to release-please - #104
Merged
Merged
Conversation
The release job pushed version bump commits directly to main, which the PCIDSS branch protection ruleset only allows through a bypass. release-please opens a release PR instead, so version bumps go through review and CodeQL like any other change. Merging the release PR creates the tag that triggers the existing npm publish workflow.
Wasseing
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the TriPSs/conventional-changelog release job with release-please (v5).
Why
The old job committed the version bump and pushed it straight to
main. Under the PCIDSS branch protection ruleset that only works through a bypass, so release commits land without review or CodeQL. Before the bypass existed it failed half-way: the tag was pushed but the commit was rejected (GH013), which orphaned v0.10.1.New flow
main→ release-please opens or updates the release PRchore(main): release X.Y.Z(bumpspackage.json,package-lock.json,.release-please-manifest.json,CHANGELOG.md).vX.Y.Ztag and GitHub release.on-push-tag-release.yaml→ npm publish (unchanged, same trusted publisher).Uses
USP_GITHUB_ADMIN_FINE_GRAINED_ACCES_TOKEN: tags and PRs created withGITHUB_TOKENdon't trigger other workflows (publish, CodeQL, lints). The token needs Contents and Pull requests read/write.Changes
on-push-main.yaml: rungoogleapis/release-please-action@v5release-manager.yamlrelease-please-config.json(node, tagsvX.Y.Z) and.release-please-manifest.json(starts at 0.10.2)Checked
release-please release-pr --dry-runagainst this branch findsv0.10.2as the latest release. With a testfix:commit on a throwaway branch it proposes 0.10.3 with tagv0.10.3. This PR itself is aci:commit, so merging it won't open a release PR.