Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Graph construction in two search tests repeatedly reconstructs vectors, adding substantial ASan/UBSan runtime. Enable the existing construction cache in those fixtures and reduce the 1025/4097-dimensional scratch-search cases from 257 to 65 points, retaining a non-complete graph with degree 32 and search window 1.
The 64/65-dimensional cases retain 257 points to cover IDs beyond 255. All dimensions, L2/IP metrics, raw/4-bit/8-bit modes, query counts, hints, ties, and assertions remain covered. Cached-versus-uncached construction parity and maximum-dimension tests are unchanged. No production code, sanitizer flags, APIs, formats, or dependencies change.
Testing
Local ASan/UBSan timings (one measurement per version, build excluded):
These two tests take 82.4% less time. Measurements used an Intel Xeon Gold 6418H, GCC 14.3.0, Linux x86-64 with AVX2/AVX-512 available and runtime dispatch, Debug builds with native optimization off, ASan leak detection and UBSan halt-on-error enabled, serial CTest pinned to CPUs 0–3, and OMP_NUM_THREADS=2.