Repository navigation
ci: narrow benchmark checks and add documentation validation gate - #155
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #154 changed benchmark display labels but triggered the complete C++ and wheel matrices because
benchmarks/build_indexes.pyfell through to the unknown-input rule.Documentation validation, while building documentation only when selected or change detection fails. Reject failed, cancelled or unexpectedly skipped selected builds.Testing
Independent local review: PASS, for the initial candidate and the discovery-timeout follow-up delta.
python -m unittest discover -s .github/scripts -p 'test_*.py' -v: 31 passed. New regressions failed against the previous implementation before the fixes.python -m pytest tests/python/test_benchmark_protocol.py -q: 12 passed, also with imports of rabitqlib, Faiss, scikit-learn, SciPy and Matplotlib blocked../scripts/check-python.sh, plus Ruff lint/format for.github/scripts: passed.shellcheck scripts/check-python.sh: passed.python -m mkdocs build --strict --config-file docs/mkdocs.yml: passed.git diff --check: passed.The complete #154 change set now selects only documentation and Python quality checks. This PR itself intentionally retains broad CI because it changes the CI selector.
Follow-up after merge
Branch protection has not been changed. After this workflow is merged and its selected-doc, failed-doc and intentional-no-doc paths are verified on GitHub, add
Documentation validationto main's required checks while preserving all existing contexts and app IDs. Do not require the new context before it is available.