Skip to content

refactor(core): share quantization math and reuse residuals - #162

Merged
gouyt13 merged 2 commits into
mainfrom
refactor/core-quantization-reuse
Oct 24, 2026
Merged

gouyt13 merged 2 commits into
mainfrom
refactor/core-quantization-reuse

Conversation

@gouyt13

@gouyt13 gouyt13 commented Oct 24, 2026

Copy link
Copy Markdown
Member

Summary

Share quantization boundary/factor arithmetic and reuse prepared residuals in multibit encoding. Add analytical factor and underflow-sign tests; shorten search comments.

Known tradeoff: controlled checks found ~2–3% slower 128D/1-bit encoding. Tested 4-bit workloads were slightly faster; 768D/9-bit was effectively unchanged.

Testing

  • 9,696 before/after code/factor cases match byte-for-byte.
  • Core: 132 passed. Full C++: 412 passed, 1 expected skip; separate OpenMP binding test passed.
  • Formatting, full clang-tidy and independent review passed. ARM/MSVC runtime checks not run.

@github-actions github-actions Bot added the release:maintenance Release category managed from the PR title label Oct 24, 2026
@gouyt13
gouyt13 merged commit e1206dc into main Oct 24, 2026
55 checks passed
@gouyt13
gouyt13 deleted the refactor/core-quantization-reuse branch October 24, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:maintenance Release category managed from the PR title

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant