Repository navigation
test: strengthen regression oracles and consolidate duplicate coverage - #168
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some regression tests could pass after the behavior they were meant to protect was broken. Strengthen the unaligned index-build oracle, verify every historical fixture manifest, enforce the tested SHA in release API mocks, and compare distinct concurrent core workloads against serial results on every iteration.
Consolidate duplicate keyword, IVF threading, popcount and XY recombination checks while retaining their effective coverage. The XY estimator test now compares against unsplit encoding. Only nine test files change; production code, APIs, persisted formats and dependencies are unchanged.
Testing
Mypy/Pyright are unavailable locally. C++ CLI examples, other platforms, repaired wheels and sanitizers were not rerun. Focused clang-tidy retains eight diagnostics on unchanged baseline test lines; no new diagnostics in the modified core test.