Skip to content

test: strengthen regression oracles and consolidate duplicate coverage - #168

Merged
gouyt13 merged 1 commit into
mainfrom
test/pre-release-test-coverage
Oct 27, 2026
Merged

gouyt13 merged 1 commit into
mainfrom
test/pre-release-test-coverage

Conversation

@gouyt13

@gouyt13 gouyt13 commented Oct 27, 2026

Copy link
Copy Markdown
Member

Summary

Some regression tests could pass after the behavior they were meant to protect was broken. Strengthen the unaligned index-build oracle, verify every historical fixture manifest, enforce the tested SHA in release API mocks, and compare distinct concurrent core workloads against serial results on every iteration.

Consolidate duplicate keyword, IVF threading, popcount and XY recombination checks while retaining their effective coverage. The XY estimator test now compares against unsplit encoding. Only nine test files change; production code, APIs, persisted formats and dependencies are unchanged.

Testing

  • Portable Clang 23 Release CTest, native optimization OFF: 409 passed, one conditional skip; the dedicated OpenMP binding test passed.
  • Current-source Python extension: 793 passed, two platform skips, one mypy test deselected; C++ CLI example tests excluded.
  • CI tooling: 48 passed. C++ formatting and Python lint passed.
  • Fault injection confirms the strengthened tests reject discarded unaligned data/centroids, incomplete fixture registration, missing release SHA filtering, transient worker factor errors and conversion corruption that the original tests missed.
  • Independent review of the complete diff passed, including focused Python/release checks, 20 repetitions of the focused C++ cases and reruns of the fault probes.

Mypy/Pyright are unavailable locally. C++ CLI examples, other platforms, repaired wheels and sanitizers were not rerun. Focused clang-tidy retains eight diagnostics on unchanged baseline test lines; no new diagnostics in the modified core test.

@github-actions github-actions Bot added the release:maintenance Release category managed from the PR title label Oct 27, 2026
@gouyt13
gouyt13 merged commit 3bb3a08 into main Oct 27, 2026
53 checks passed
@gouyt13
gouyt13 deleted the test/pre-release-test-coverage branch October 27, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:maintenance Release category managed from the PR title

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant