Skip to content

feat: rename the Venus vault Active state to Supply - #5793

Merged
cuzz-venus merged 8 commits into
mainfrom
feat/vault-state-rename
Aug 28, 2026
Merged

feat: rename the Venus vault Active state to Supply#5793
cuzz-venus merged 8 commits into
mainfrom
feat/vault-state-rename

Conversation

@cuzz-venus

@cuzz-venus cuzz-venus commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Jira ticket(s)

VPD-1896

Changes

  • rename the Venus vault Active state to Supply: unpaused Venus vaults now report the existing Deposit state, whose label already reads "Supply", and VaultStatus.Active is removed
  • point both Supply badges at a single translation key, since they diverged in zh-Hans (供应 vs 存款)
  • map the legacy ?status=active filter link onto the Supply state and rewrite it in the URL

XVS and VAI vaults were badged "Active" while every other depositable
vault is badged "Supply", giving the same meaning two labels. Venus
vaults now report the Deposit state, whose label already reads "Supply",
and the duplicate "Active" option is gone from the state filter.

Links shared while the "Active" state existed are redirected to the
Supply state so they keep resolving to the same vaults.

VPD-1896
@vercel

vercel Bot commented Aug 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dapp-preview Ready Ready Preview Aug 28, 2026 2:22am
dapp-testnet Ready Ready Preview Aug 28, 2026 2:22am
venus.io Ready Ready Preview Aug 28, 2026 2:22am

Request Review

@changeset-bot

changeset-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5f6dc6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@venusprotocol/evm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 80.78% 52097 / 64492
🔵 Statements 80.78% 52097 / 64492
🔵 Functions 74.58% 1602 / 2148
🔵 Branches 86.06% 7687 / 8932
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/evm/src/clients/api/queries/useGetVaults/formatToVenusVault/index.tsx 100% 66.66% 100% 100%
apps/evm/src/components/StatusLabel/index.tsx 84.61% 64.7% 100% 84.61% 21-22, 38-39, 47-48, 56-57, 59-60
apps/evm/src/hooks/useSortVaults/index.ts 100% 100% 100% 100%
apps/evm/src/hooks/useSortVaults/getVaultApyPercentage/index.ts 100% 100% 100% 100%
apps/evm/src/hooks/useSortVaults/getVaultDeploymentTimestampMs/index.ts 75% 50% 100% 75% 6
apps/evm/src/pages/Dashboard/Vaults/index.tsx 100% 81.81% 100% 100%
apps/evm/src/pages/Vaults/index.tsx 90.9% 50% 100% 90.9% 20-21
apps/evm/src/pages/Vaults/VaultList/hooks/useFilterOptions.tsx 92% 100% 40% 92% 52-55, 58-61, 64-67
apps/evm/src/types/index.ts 100% 100% 100% 100%
apps/evm/src/utilities/compareNumbersWithMissingLast.ts 100% 100% 100% 100%
apps/evm/src/utilities/index.ts 100% 100% 100% 100%
Generated in workflow #14184 for commit 5f6dc6e by the Vitest Coverage Report Action

@cuzz-venus

Copy link
Copy Markdown
Contributor Author

@greptile review again

@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown

Greptile Summary

The PR consolidates the Venus vault “Active” state into the existing “Deposit” state displayed as “Supply.”

  • Migrates status formatting, labels, translations, filters, mocks, and tests from Active to Deposit.
  • Rewrites legacy ?status=active links to status=deposit while preserving the other query parameters.
  • Introduces shared vault sorting by action tier, return, deployment time, and TVL, and applies it to discovery and dashboard views.

Confidence Score: 4/5

The PR appears safe to merge, with only a non-blocking repository-structure issue in the new comparison utility.

The status migration, legacy URL handling, and shared sorting remain internally aligned; the only accepted concern is that the new utility is placed outside the required dedicated function directory.

Files Needing Attention: apps/evm/src/utilities/compareNumbersWithMissingLast.ts

Important Files Changed

Filename Overview
apps/evm/src/clients/api/queries/useGetVaults/formatToVenusVault/index.tsx Consistently maps usable Venus vaults to Deposit while retaining the existing paused-state safeguards.
apps/evm/src/pages/Vaults/VaultList/hooks/useFilterOptions.tsx Removes the Active option, adds Paused, validates status values, and migrates legacy Active URLs without an update loop.
apps/evm/src/hooks/useSortVaults/index.ts Centralizes deterministic vault ordering with explicit handling for missing or invalid numeric values.
apps/evm/src/types/index.ts Removes VaultStatus.Active after producers and consumers are migrated to Deposit.
apps/evm/src/utilities/compareNumbersWithMissingLast.ts Correctly sorts missing numeric values last but violates the required dedicated-directory convention.

Reviews (1): Last reviewed commit: "feat: add changeset" | Re-trigger Greptile

@cuzz-venus
cuzz-venus merged commit aeae33b into main Aug 28, 2026
5 checks passed
@cuzz-venus
cuzz-venus deleted the feat/vault-state-rename branch August 28, 2026 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant