feat: rename the Venus vault Active state to Supply - #5793
Conversation
XVS and VAI vaults were badged "Active" while every other depositable vault is badged "Supply", giving the same meaning two labels. Venus vaults now report the Deposit state, whose label already reads "Supply", and the duplicate "Active" option is gone from the state filter. Links shared while the "Active" state existed are redirected to the Supply state so they keep resolving to the same vaults. VPD-1896
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 5f6dc6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
044b295 to
0d29c89
Compare
ada467f to
a661ab4
Compare
|
@greptile review again |
Greptile SummaryThe PR consolidates the Venus vault “Active” state into the existing “Deposit” state displayed as “Supply.”
Confidence Score: 4/5The PR appears safe to merge, with only a non-blocking repository-structure issue in the new comparison utility. The status migration, legacy URL handling, and shared sorting remain internally aligned; the only accepted concern is that the new utility is placed outside the required dedicated function directory. Files Needing Attention: apps/evm/src/utilities/compareNumbersWithMissingLast.ts
|
| Filename | Overview |
|---|---|
| apps/evm/src/clients/api/queries/useGetVaults/formatToVenusVault/index.tsx | Consistently maps usable Venus vaults to Deposit while retaining the existing paused-state safeguards. |
| apps/evm/src/pages/Vaults/VaultList/hooks/useFilterOptions.tsx | Removes the Active option, adds Paused, validates status values, and migrates legacy Active URLs without an update loop. |
| apps/evm/src/hooks/useSortVaults/index.ts | Centralizes deterministic vault ordering with explicit handling for missing or invalid numeric values. |
| apps/evm/src/types/index.ts | Removes VaultStatus.Active after producers and consumers are migrated to Deposit. |
| apps/evm/src/utilities/compareNumbersWithMissingLast.ts | Correctly sorts missing numeric values last but violates the required dedicated-directory convention. |
Reviews (1): Last reviewed commit: "feat: add changeset" | Re-trigger Greptile
Jira ticket(s)
VPD-1896
Changes
Activestate toSupply: unpaused Venus vaults now report the existingDepositstate, whose label already reads "Supply", andVaultStatus.Activeis removedzh-Hans(供应vs存款)?status=activefilter link onto the Supply state and rewrite it in the URL